Skip to content

Clean up logging from NoTargets projects #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffkl merged 4 commits into from
Nov 4, 2021
Merged

Clean up logging from NoTargets projects #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd76fc6
Clean up logging from NoTargets projects
AArnott Oct 9, 2021
0ee1380
Add unit test for change
AArnott Oct 25, 2021
fe266ee
Add condition
AArnott Oct 25, 2021
3232137
Merge branch 'main' into patch-1
jeffkl Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/NoTargets.UnitTests/NoTargetsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ public void ProjectsCanDependOnNoTargetsProjects()
[InlineData("GenerateMSBuildEditorConfigFile", "false")]
[InlineData("IncludeBuildOutput", "false")]
[InlineData("ProduceReferenceAssembly", "false")]
[InlineData("SkipCopyBuildProduct", "true")]
public void PropertiesHaveExpectedValues(string propertyName, string expectedValue)
{
ProjectCreator.Templates.NoTargetsProject(
Expand Down
3 changes: 3 additions & 0 deletions src/NoTargets/Sdk/Sdk.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@

<!-- Don't generate editor config file -->
<GenerateMSBuildEditorConfigFile Condition="'$(GenerateMSBuildEditorConfigFile)' == ''">false</GenerateMSBuildEditorConfigFile>

<!-- Don't log the high priority message mentioning this project's name (or copy the product we didn't build). -->
<SkipCopyBuildProduct Condition="'$(SkipCopyBuildProduct)' == ''">true</SkipCopyBuildProduct>
</PropertyGroup>

<ItemDefinitionGroup Condition=" '$(NoTargetsDoNotReferenceOutputAssemblies)' != 'false' ">
Expand Down