Skip to content

Fix issue with CentralPackageVersions logging error when using a custom import pattern.#325

Merged
jeffkl merged 1 commit intomicrosoft:mainfrom
jeffkl:fix-error-for-custom-import-pattern
Dec 2, 2021
Merged

Fix issue with CentralPackageVersions logging error when using a custom import pattern.#325
jeffkl merged 1 commit intomicrosoft:mainfrom
jeffkl:fix-error-for-custom-import-pattern

Conversation

@jeffkl
Copy link
Contributor

@jeffkl jeffkl commented Dec 2, 2021

#322 didn't take into account that if Microsoft.Build.CentralPackageVersions is imported in a custom way. This change now makes sure it was imported after Microsoft.Common.targets

Fixes #324

…om import pattern.

#322 didn't take into account that if Microsoft.Build.CentralPackageVersions is imported in a custom way.  This change now makes sure it was imported after Microsoft.Common.targets

Fixes #324
@jeffkl jeffkl merged commit 99a3dc3 into microsoft:main Dec 2, 2021
@jeffkl jeffkl deleted the fix-error-for-custom-import-pattern branch December 2, 2021 20:31
jeffkl added a commit that referenced this pull request Dec 3, 2021
…g a custom import pattern" (#327)

* Revert "Fix issue with CentralPackageVersions logging error when using a custom import pattern. (#325)"

This reverts commit 99a3dc3.

* Revert "Log an error if imported in Directory.Build.props (#322)"

This reverts commit af63eab.

Reopens #324 and #179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Log an error if imported in Directory.Build.props PR" breaks custom project structure

1 participant

Comments