Set properties to disable symbols and Visual Studio fast up-to-date check#343
Merged
jeffkl merged 3 commits intomicrosoft:mainfrom May 5, 2022
Merged
Set properties to disable symbols and Visual Studio fast up-to-date check#343jeffkl merged 3 commits intomicrosoft:mainfrom
jeffkl merged 3 commits intomicrosoft:mainfrom
Conversation
jeffkl
reviewed
Mar 7, 2022
Contributor
jeffkl
left a comment
There was a problem hiding this comment.
Please update this unit test to check for the expected defaults in case anything ever messes with these properties
MSBuildSdks/src/NoTargets.UnitTests/NoTargetsTests.cs
Lines 157 to 176 in 291b172
jeffkl
approved these changes
May 5, 2022
Contributor
jeffkl
left a comment
There was a problem hiding this comment.
Thanks for the contribution, I went ahead and pushed an update to the unit test so I get merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to NoTargets SDK props:
Documentation regarding Visual Studio's Up-to-date Check:
https://github.com/dotnet/project-system/blob/main/docs/up-to-date-check.md#disabling-the-up-to-date-check