Add ability to skip projects dynamically in Traversal projects and Visual Studio solution files#439
Merged
jeffkl merged 2 commits intomicrosoft:mainfrom Apr 26, 2023
jeffkl:skipprojects
Merged
Add ability to skip projects dynamically in Traversal projects and Visual Studio solution files#439jeffkl merged 2 commits intomicrosoft:mainfrom jeffkl:skipprojects
jeffkl merged 2 commits intomicrosoft:mainfrom
jeffkl:skipprojects
Conversation
…sual Studio solution files
|
@jeffkl, this looks like a breaking change when upgrading to 4.0.0 as it requires defining a ShouldSkipProject target even if you do not want to skip anything. Why not define an empty ShouldSkipProject target in the SDK? |
Contributor
Author
|
@avivanoff the target that is called is in the projects referenced by Traversal which do not import Traversal, so Traversal cannot inject the target. But the MSBuild call should pass ed27e69#diff-8a55a07e0ced81492f6e4a15a3f60dda3917fdf5d11c11754d61f705ea3fa272R271 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the ability to dynamically skip projects when building a Traversal project or Visual Studio solution file. Users need to implement a target in
Directory.Build.targets, the project itself, or some other import:This example skips VSIX projects when building with
dotnet build:Users can also now extend Visual Studio solution file builds with Microsoft.Build.Traversal to get the same functionality. To do this, they must create a
Directory.Solution.propsandDirectory.Solution.targetsnext to the solution file:Directory.Solution.props:
Directory.Solution.targets:
This gives them the ability to dynamically skip projects in the same way.