-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asser-M365DSCBlueprint: add additional Auth Meth to Asser-M365DSCBlueprint #1792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also update the changelog to reflect this change?
@NikCharlebois Can you please also check this PR? Not 100% if this will work for this function. |
@Timsto This function should not handle credentials. It is purely meant to retrieve the domain if service principal if passed. If credentials are used, then determining the domain is very easy and straightforward: $domain = $credentials.UserName.Split('@')[1] |
@NikCharlebois and @Timsto Are there any updates to this PR? At the moment there are two tasks open:
|
[Parameter()] | ||
[System.Management.Automation.PSCredential] | ||
$Credential, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as mentioned in #1792 (comment) this function should not handle any Credentials.
@Timsto have you had a chance to look at the comments? Should we keep this PR open or close it? |
Closing this PR due to inactivity, but code will be adopted in a different PR I am working on. |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues