Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: IntuneDeviceConfigurationAdministrativeTemplatePolicyWindows10 - Initial release - Fix 2833 #3145

Merged
merged 17 commits into from
Apr 12, 2023
Merged

PR: IntuneDeviceConfigurationAdministrativeTemplatePolicyWindows10 - Initial release - Fix 2833 #3145

merged 17 commits into from
Apr 12, 2023

Conversation

William-Francillette
Copy link
Contributor

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

  • IntuneDeviceConfigurationAdministrativeTemplatePolicyWindows10
    • Initial release
      FIXES #2833

@William-Francillette
Copy link
Contributor Author

Added missing stub to fix unit test

ykuijs
ykuijs requested changes Apr 11, 2023
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question on some code that is commented out

...latePolicyWindows10/MSFT_IntuneDeviceConfigurationAdministrativeTemplatePolicyWindows10.psm1 Outdated Show resolved Hide resolved
@ricmestre ricmestre mentioned this pull request Apr 11, 2023
Closed
@ykuijs
Copy link
Member

ykuijs commented Apr 11, 2023

QQ: If these properties are Read-Only, is there a reason that they are still mentioned in the schema.mof file?

@William-Francillette
Copy link
Contributor Author

QQ: If these properties are Read-Only, is there a reason that they are still mentioned in the schema.mof file?

I didn't want them to generate an error in the export or the compilation
They are returned in the export but are not tested and not added in the update. I just wanted the export to be more readable otherwise the setting would have been an id and not really readable. The definition parameter is not required for the resource but it gives all the information about the setting.

@William-Francillette
Copy link
Contributor Author

This resource was quite a tricky one as hundreds of settings are available and they are split in definition and presentation Definition.
I also used the rest query to update presentation value as it is not available in the sdk and will be released in 2.0
This resource has been requested a few times so wanted to release it asap

ykuijs
ykuijs approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ykuijs
ykuijs reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few updates required to fix the unit tests

...DSC/Microsoft365DSC.IntuneDeviceConfigurationAdministrativeTemplatePolicyWindows10.Tests.ps1 Outdated Show resolved Hide resolved
...DSC/Microsoft365DSC.IntuneDeviceConfigurationAdministrativeTemplatePolicyWindows10.Tests.ps1 Show resolved Hide resolved
@William-Francillette
Copy link
Contributor Author

@ykuijs Should be good to go

ykuijs
ykuijs approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit 4f8ee11 into microsoft:Dev Apr 12, 2023
@William-Francillette William-Francillette deleted the IntuneDeviceConfigurationAdministrativeTemplatePolicyWindows10 branch July 8, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykuijs ykuijs ykuijs approved these changes

@NikCharlebois NikCharlebois Awaiting requested review from NikCharlebois NikCharlebois is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IntuneAdministrativeTemplateWindows10: New resource proposal
2 participants
@William-Francillette @ykuijs