This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
Add tests for video camera video recording and fix subsequent recording #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents to help with debugging encoder issues
… with adding compositor scene
chrisfromwork
changed the title
Fix video camera recording bug and add tests
Add tests for video camera video recording
Sep 12, 2019
chrisfromwork
added
the
breaking change
Pull request contains a breaking change and requires additional information.
label
Sep 12, 2019
chrisfromwork
changed the title
Add tests for video camera video recording
Add tests for video camera video recording and fix subsequent recording
Sep 23, 2019
matthejo
reviewed
Sep 25, 2019
src/SpectatorView.Native/SpectatorView.Compositor/Compositor/VideoEncoder.cpp
Show resolved
Hide resolved
matthejo
reviewed
Sep 25, 2019
src/SpectatorView.Native/SpectatorView.Compositor/Compositor/CompositorInterface.cpp
Outdated
Show resolved
Hide resolved
matthejo
reviewed
Sep 25, 2019
src/SpectatorView.Native/SpectatorView.Compositor/Compositor/CompositorInterface.cpp
Outdated
Show resolved
Hide resolved
matthejo
reviewed
Sep 25, 2019
src/SpectatorView.Unity/Assets/SpectatorView/Scripts/Compositor/UnityCompositorInterface.cs
Outdated
Show resolved
Hide resolved
matthejo
reviewed
Sep 25, 2019
src/SpectatorView.Unity/Assets/SpectatorView/Scripts/Compositor/CompositionManager.cs
Outdated
Show resolved
Hide resolved
matthejo
reviewed
Sep 25, 2019
src/SpectatorView.Unity/Assets/SpectatorView/Scripts/Compositor/CompositionManager.cs
Outdated
Show resolved
Hide resolved
matthejo
reviewed
Sep 25, 2019
add spectator view changes to pick file name
…le times for audio
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This review contains a few items:
SpectatorView.Compositor.UnityPlugin no longer tries to interpolate between video and audio times. There is now an assumption that audio samples/video samples will be provided by the unity editor based on the same start time.
Audio sample time provided from the Unity editor is now based off of the captured frame index + frame sample lengths. This prevents needing to interpolate between the AudioSettings.dspTime and the CaptureFrameIndex time. Previous calculations for doing this in the native plugin did not work correctly and seemed unnecessary. Interpolations between AudioSettings.dspTime and CaptureFrameIndex time can be conducted in the Unity editor as needed.
We now have tests to ensure that textures get created for both the elgato and black magic design frame providers when starting the SpectatorViewCompositor scene.
We now have tests for recording and playing videos recorded with the SpectatorViewCompositor scene.
SpectatorView.Compositor & SpectatorView.Compositor.UnityPlugin now return video file names when starting recording so that tests can cleanup generated files.
Breaking Change Details:
Notes:
This change fixes video encoding issues that occur when recording videos with the Video Camera filming solution. It redefines the UnityCompositorInterface and is therefore a breaking change (requires recompiling associated dlls). This break allows the editor to know the name of the video file recorded, which allows for playmode test cleanup.
Migration Instructions:
To migrate to codebases using this change, users need to do the following: