This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Change build name to avoid errors for iOS and fix TextMeshPro #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfromwork
requested review from
andreiborodin,
wiwei,
matthejo and
grbury
chrisfromwork
changed the title
chrisfromwork
added
the
breaking change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
individual developers don't seem able to use project names containing Microsoft. To avoid confusion/signing errors, we should remove Microsoft from our sample name.
In this review, we also move to the newest version of text mesh pro. With older versions of text mesh pro it seems that asset syncing does not work correctly for iOS.
Breaking Change Details:
Notes:
TextMeshPro was upgraded from 1.3.0 to 1.4.1 to fix iOS synchronization.
Migration Instructions: