Fix simulated motion controller grab #11272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloehr
requested review from
david-c-kline,
keveleigh and
MaxWang-MS
as code owners
keveleigh
approved these changes
Dec 6, 2022
|
@jloehr Thanks for this fix! I've prioritized it for the upcoming 2.8.3 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Simulated motion controller grab wasn't working in Editor, because it raised a float input event instead of a boolean.
This PR fixes this, by changing the input event to boolean, like the simulated grab for articulated hands.
Verification
Create a new scene with the MRTK rig. Make sure to use profiles that use the Motion Controller Simulation Mode (Input -> Input Data Providers -> Input Simulation Service -> Default Controller Simulation Mode:
Motion Controller)Add a simple cube to the scene with an
Object Manipulatorwith disabled far manipulation and aNearInteractionGrabbable. In Play Mode, use either the left or right controller and the mapped grab key (DefaultG) to grab and move the cube.