Hand Constrained Solver (useful for Hand UI) #4532

Cameron-Micka · 2019-05-22T21:43:18Z

Overview

These changes introduce a new type of solver called "HandConstraint." The HandConstraint provides a solver that constrains the tracked object to a region safe for hand constrained content. (Such as hand UI/menus.) Safe regions are considered areas that don't intersect with the hand.

HandUIExample Scene:

A derived class of HandConstraint called "HandConstraintPalmUp" is also included to demonstrate a common behavior of activating the solver tracked object when the palm is facing the user. For example use of this behavior please see the HandUIExample scene.

Finally, a new utility class called "HandBounds" has been added to help classes access the AABB bounds of the articulated hands.

Changes

Fixes: Hand Constained UI #4531

Verification

Please check out the HandUIExample scene to verify example use of the solver.

I think that this step used to build nuget packages as well, until we did the later NuGet work (of packing it up at the end of CI). However, this text appears to have stuck around. Note that the command it runs actually says "NoNuget"

…RealityToolkit-Unity into mrtk_development_hand_menu

…ents.

danielescudero · 2019-05-22T21:54:34Z

@Cameron-Micka lets chat :)

Cameron-Micka · 2019-05-31T00:41:56Z

Cameron, there was a good suggestion to communicate somewhere in the inspector that this is an experimental feature. Something like "This is an experimental feature."
Then, a tooltip / detail view could read: "Some things the MRTK works on appear to have a lot of initial value even if we haven’t fully fleshed out the details. For these types of features, we want the community to get a chance to see them and get value out of them early. Because they are early in the cycle, we label them as experimental to indicate that they are still evolving, and subject to change over time."

Sounds good! I'll add an attribute and tag the class as experimental.

wiwei · 2019-05-31T02:59:46Z

/azp run mrtk_pr

azure-pipelines · 2019-05-31T02:59:56Z

Azure Pipelines failed to run 1 pipeline(s).

Cameron-Micka · 2019-05-31T19:27:36Z

@julenka I added an [Experimental] tag decorator drawer so that developers in the futre can easily tag implmentation as experimental without writing custom inspectors. You can see how it looks below:

Cameron-Micka · 2019-05-31T19:28:58Z

We would love to get this in for RC2, so please let me know if anything else should be addressed.

Cameron-Micka · 2019-05-31T19:29:30Z

/azp run mrtk_pr

azure-pipelines · 2019-05-31T19:29:42Z

Azure Pipelines successfully started running 1 pipeline(s).

julenka · 2019-06-01T05:17:39Z

Thanks Cameron! I've completed this into the rc2 stabilization branch based on your request that you wanted to get this into stabilization. We have mostly been trying to only take in critical fixes to allow us time to stabilize. However you made this PR quite early in the week and I think the impact on the rest of MRTK is minimal, so it should be fine.

Cameron-Micka · 2019-06-01T14:33:18Z

Thank you Julia!

@Troy-Ferrell

## Overview This pull request moves the HandConstraint (and HandConstraintPalmUp) solver from Experimental to Release by adding tests, documentation, and a handful of bug fixes and improvements. Functionality remains pretty much the same from the previous pull request (#4532) and utilizes solver fixes from @Troy-Ferrell's (#5416) The solver has also be genericized to work with motion controllers. Thank you @julenka for guidance on how to write unit tests that utilize hands! ## Changes - Fixes: #5312, #5304, #5257, #5413 ## Commits * Removing global input handler warning. * Wip check-in, new rotation behavior. * Disable hand tracking on hands which are currently focus locked. * Adding additional hand menu features and documentation improvements. * Hand constraint example improvements. * Hacks to get solver to not throw null pointers when instantiated. Should be reverted * Skeleton test for ensuring hand menu follows hand * Comment and example improvements. * autoTransitionBetweenHands is now set via the tracked handness of the solver handler * Adding support for motion controllers. * Updating example to support new solver changes. * Moving hand based menus out of the experimental namespace. * Adding hand constraint documentation. * Addressing pr feedback. * Updating example scene to use "new" toggle buttons. * Improving documentation, especially around IMixedRealityControllers usage. * Fixing broken documentation. * Update Documentation/README_Solver.md

@Troy-Ferrell

…Constraint (and HandConstraintPalmUp) solver from Experimental to Release by adding tests, documentation, and a handful of bug fixes and improvements. Functionality remains pretty much the same from the previous pull request (#4532) and utilizes solver fixes from @Troy-Ferrell's (#5416) The solver has also be genericized to work with motion controllers. Thank you @julenka for guidance on how to write unit tests that utilize hands! ## Changes - Fixes: #5312, #5304, #5257, #5413 ## Commits * Removing global input handler warning. * Wip check-in, new rotation behavior. * Disable hand tracking on hands which are currently focus locked. * Adding additional hand menu features and documentation improvements. * Hand constraint example improvements. * Hacks to get solver to not throw null pointers when instantiated. Should be reverted * Skeleton test for ensuring hand menu follows hand * Comment and example improvements. * autoTransitionBetweenHands is now set via the tracked handness of the solver handler * Adding support for motion controllers. * Updating example to support new solver changes. * Moving hand based menus out of the experimental namespace. * Adding hand constraint documentation. * Addressing pr feedback. * Updating example scene to use new toggle buttons. * Improving documentation, especially around IMixedRealityControllers usage. * Fixing broken documentation. * Update Documentation/README_Solver.md )

@Troy-Ferrell

…oft#5500) ## Overview This pull request moves the HandConstraint (and HandConstraintPalmUp) solver from Experimental to Release by adding tests, documentation, and a handful of bug fixes and improvements. Functionality remains pretty much the same from the previous pull request (microsoft#4532) and utilizes solver fixes from @Troy-Ferrell's (microsoft#5416) The solver has also be genericized to work with motion controllers. Thank you @julenka for guidance on how to write unit tests that utilize hands! ## Changes - Fixes: microsoft#5312, microsoft#5304, microsoft#5257, microsoft#5413 ## Commits * Removing global input handler warning. * Wip check-in, new rotation behavior. * Disable hand tracking on hands which are currently focus locked. * Adding additional hand menu features and documentation improvements. * Hand constraint example improvements. * Hacks to get solver to not throw null pointers when instantiated. Should be reverted * Skeleton test for ensuring hand menu follows hand * Comment and example improvements. * autoTransitionBetweenHands is now set via the tracked handness of the solver handler * Adding support for motion controllers. * Updating example to support new solver changes. * Moving hand based menus out of the experimental namespace. * Adding hand constraint documentation. * Addressing pr feedback. * Updating example scene to use "new" toggle buttons. * Improving documentation, especially around IMixedRealityControllers usage. * Fixing broken documentation. * Update Documentation/README_Solver.md

@Troy-Ferrell

…#5560) * Moving the HandConstraint Solver from Experimental to Release (#5500) ## Overview This pull request moves the HandConstraint (and HandConstraintPalmUp) solver from Experimental to Release by adding tests, documentation, and a handful of bug fixes and improvements. Functionality remains pretty much the same from the previous pull request (#4532) and utilizes solver fixes from @Troy-Ferrell's (#5416) The solver has also be genericized to work with motion controllers. Thank you @julenka for guidance on how to write unit tests that utilize hands! ## Changes - Fixes: #5312, #5304, #5257, #5413 ## Commits * Removing global input handler warning. * Wip check-in, new rotation behavior. * Disable hand tracking on hands which are currently focus locked. * Adding additional hand menu features and documentation improvements. * Hand constraint example improvements. * Hacks to get solver to not throw null pointers when instantiated. Should be reverted * Skeleton test for ensuring hand menu follows hand * Comment and example improvements. * autoTransitionBetweenHands is now set via the tracked handness of the solver handler * Adding support for motion controllers. * Updating example to support new solver changes. * Moving hand based menus out of the experimental namespace. * Adding hand constraint documentation. * Addressing pr feedback. * Updating example scene to use "new" toggle buttons. * Improving documentation, especially around IMixedRealityControllers usage. * Fixing broken documentation. * Update Documentation/README_Solver.md * Update Documentation/README_Solver.md Co-Authored-By: David Kline <davidkl@microsoft.com>

@Troy-Ferrell

…rimental to Release (#5500) ## Overview This pull request moves the HandConstraint (and HandConstraintPalmUp) solver from Experimental to Release by adding tests, documentation, and a handful of bug fixes and improvements. Functionality remains pretty much the same from the previous pull request (#4532) and utilizes solver fixes from @Troy-Ferrell's (#5416) The solver has also be genericized to work with motion controllers. Thank you @julenka for guidance on how to write unit tests that utilize hands! ## Changes - Fixes: #5312, #5304, #5257, #5413 ## Commits * Removing global input handler warning. * Wip check-in, new rotation behavior. * Disable hand tracking on hands which are currently focus locked. * Adding additional hand menu features and documentation improvements. * Hand constraint example improvements. * Hacks to get solver to not throw null pointers when instantiated. Should be reverted * Skeleton test for ensuring hand menu follows hand * Comment and example improvements. * autoTransitionBetweenHands is now set via the tracked handness of the solver handler * Adding support for motion controllers. * Updating example to support new solver changes. * Moving hand based menus out of the experimental namespace. * Adding hand constraint documentation. * Addressing pr feedback. * Updating example scene to use new toggle buttons. * Improving documentation, especially around IMixedRealityControllers usage. * Fixing broken documentation. * Update Documentation/README_Solver.md * Update Documentation/README_Solver.md Co-Authored-By: David Kline <davidkl@microsoft.com> )

wiwei and others added 21 commits May 15, 2019 16:53

Multi-scene editor testing support, multiple instances tests

d480d61

Merge branch 'mrtk_development' into mrtk_multiple_instances_tests

dd3d14f

Completed merge

539c93a

Updated playmode tests

9924f27

Adding comments, clarifying method names

708f0e4

WIP hand constraint

d72e02d

Adding hand present events

add70f9

Merge branch 'mrtk_development' of https://github.com/Microsoft/Mixed…

f2e7663

…RealityToolkit-Unity into mrtk_development_hand_menu

Wip checkin

0b1dc0e

Merge branch 'mrtk_development' into mrtk_multiple_instances_tests

1794026

Update TestUtilities.cs

ea1737f

WIP checkin.

db53566

Merge branch 'mrtk_development' of https://github.com/Microsoft/Mixed…

9017cbd

…RealityToolkit-Unity into mrtk_development_hand_menu

WIP

33d05ba

Hand safe zone feature.

cdd6669

Documentation pass

bc00345

Changing to angles

ef8add6

Fixing a bug around cursor activation.

b98a3d2

Merge branch 'mrtk_development' of https://github.com/Microsoft/Mixed…

74c167a

…RealityToolkit-Unity into mrtk_development_hand_menu

Adding options to auto billboard the tracked object and additional ev…

38ffe28

…ents.

Cameron-Micka added the ISV label May 22, 2019

Cameron-Micka assigned julenka, radicalad, Railboy, david-c-kline and cre8ivepark May 22, 2019

Merge branch 'mrtk_development' into mrtk_multiple_instances_tests

0a92383

Cameron-Micka changed the title ~~Mrtk development hand menu~~ Hand Constrained Solver (useful for Hand UI) May 23, 2019

Cameron-Micka closed this May 31, 2019

Cameron-Micka reopened this May 31, 2019

julenka changed the base branch from mrtk_development to prerelease/2.0.0.rc2_stabilization June 1, 2019 05:17

julenka merged commit 3f46739 into microsoft:prerelease/2.0.0.rc2_stabilization Jun 1, 2019

This was referenced Jun 3, 2019

Experimental Attribute #4688

Closed

Re-targeting Experimental Property for Stabilization #4690

Merged

This was referenced Jun 3, 2019

Pinch Slider: Add snap points to pinch slider #4140

Closed

RC2 Notes #4184

Closed

chbecker-ms mentioned this pull request Jun 7, 2019

How to attach an object to a hand joint #4573

Closed

julenka mentioned this pull request Jun 27, 2019

launch browser example #5047

Merged

Cameron-Micka mentioned this pull request Aug 2, 2019

Moving the HandConstraint Solver from Experimental to Release #5500

Merged

julenka mentioned this pull request Aug 9, 2019

Moving the HandConstraint Solver from Experimental to Release (#5500) #5560

Merged

This was referenced Aug 13, 2019

Added follow behavior used in OOBE (based on follow behavior from shell) #5611

Closed

Follow Solver (experimental) #5713

Closed

julenka mentioned this pull request Jan 2, 2020

Slider thumb visual orientation #6963

Merged

klasaf mentioned this pull request Jan 7, 2020

Added Basic Dialog for compatibility with old MixedRealityToolkit #6925

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hand Constrained Solver (useful for Hand UI) #4532

Hand Constrained Solver (useful for Hand UI) #4532

Cameron-Micka commented May 22, 2019

danielescudero commented May 22, 2019

Cameron-Micka commented May 31, 2019

wiwei commented May 31, 2019

azure-pipelines bot commented May 31, 2019

Cameron-Micka commented May 31, 2019

Cameron-Micka commented May 31, 2019

Cameron-Micka commented May 31, 2019

azure-pipelines bot commented May 31, 2019

julenka commented Jun 1, 2019 •

edited

Loading

Cameron-Micka commented Jun 1, 2019

Hand Constrained Solver (useful for Hand UI) #4532

Hand Constrained Solver (useful for Hand UI) #4532

Conversation

Cameron-Micka commented May 22, 2019

Overview

Changes

Verification

danielescudero commented May 22, 2019

Cameron-Micka commented May 31, 2019

wiwei commented May 31, 2019

azure-pipelines bot commented May 31, 2019

Cameron-Micka commented May 31, 2019

Cameron-Micka commented May 31, 2019

Cameron-Micka commented May 31, 2019

azure-pipelines bot commented May 31, 2019

julenka commented Jun 1, 2019 • edited Loading

Cameron-Micka commented Jun 1, 2019

julenka commented Jun 1, 2019 •

edited

Loading