This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Merge master into temp/docs #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating readme with latest feedback.
…oft#40) * Initial checkin * Move to Hosted Mac pool * Update README.md * Manually copied naming changes over from master. * Revert "Merge remote-tracking branch 'upstream/temp/docs'" This reverts commit 93c7347, reversing changes made to 2350069. * Improve documentation regarding contributors. * Fix email address.
Update scikit-learn website links to use https instead of http
…r the tree based predictors. (microsoft#298)
* Remove unnecessary code from Pipeline.transform that was causing a bug * Update release-next.md * Remove y argument from transform() method * Update release-next.md * Fix test
…ions of Python) (microsoft#297) * Update Schema.py to remove the non-ASCII character * Update build.cmd * Update build.cmd * Update build.cmd * Revert "Update build.cmd" This reverts commit cb79b9d. * Upgreate pip for all Python versions
* Add PFI entrypoint * Add PFI to Pipeline and BasePipelineItem, and examples * Improved docs and sample * Load model as PredictorModel, and remove label column and group ID column from EP inputs * schema example reference * Add test * nit * Update release-next.md * Add tests to check PFI from loaded model * Make SgdBinaryClassifier deterministic in test_estimator_checks.py * Update ML.NET nugets to 1.4.0-preview2 and 0.16.0-preview2 * Fix test baseline values * Fix Ranking PFI column names to work with with Py2.7 and Py3.5
…icrosoft#290) * Add support for DateTime output. * Add support for DateTime input columns. * Add unit test for DateTime column input and output. * Fix DateTime.Kind == Unspecified output from dprep. * Update the csproj files to point to the latest nuget packages. * Update the Tensorflow.NET library version. * Fix azureml dprep not available for Python 2.7 * Fix missing sys import. * Fix broken assertEqual on Python 3.5.
* Add test for fitting a BinaryDataStream. * Use BinaryDataStream schema for retrieving feature columns in _init_graph_nodes. * Add idv schema to BinaryDataStream. * Fix DprepDataStream was passing in incorrect value to base class constructor. * Remove column position check from unit test since it is unreliable on Python 3.5 and 2.7.
* Temporarily change running Mac pipeline to Python 3.6 * Temporary addition to view state of "result" in MacOS with Python 3.6 * Added additional temporary Python builds on Mac * Added libtensorflow_framework.so.1 (microsoft#310) * Revert "Temporary addition to view state of "result" in MacOS with Python 3.6" This reverts commit d116dc8. * Updated test_data_with_missing.test_input_conversion_to_float() * Update test_data_with_missing.py * Revert "Added additional temporary Python builds on Mac" This reverts commit 1aa1526. * Revert "Temporarily change running Mac pipeline to Python 3.6" This reverts commit 4ec36fb.
* draft * draft * rollback * new entrypoint * add assert * rollback * no print in test * up version * only Single type is allowed for Feature vector * fix comments, rename entrypoint * convert to single * fix type * add feature contribution test * rename pipeline.get_schema() to pipeline.gat_output_columns() * fix build
pieths
reviewed
Oct 10, 2019
src/python/nimbusml.pyproj
Outdated
| @@ -30,69 +30,70 @@ | |||
| <Compile Include="docs\sphinx\conf.py" /> | |||
| <Compile Include="nimbusml\base_predictor.py" /> | |||
| <Compile Include="nimbusml\base_transform.py" /> | |||
| <Compile Include="nimbusml\cluster\_kmeansplusplus.py" /> | |||
| <Compile Include="nimbusml\cluster\kmeansplusplus.py" /> | |||
There was a problem hiding this comment.
Why were these renamed (see all changes in the file)? kmeansplusplus.py (and all the other files) without the underscore should not exist. They should have been renamed to have an underscore as the first letter.
pieths
reviewed
Oct 10, 2019
src/python/nimbusml.pyproj
Outdated
| <Content Include="nimbusml\datasets\_data\train-ticketchoice.csv" /> | ||
| <Content Include="nimbusml\datasets\_data\train-twitter.gen-sample.tsv" /> | ||
| <Content Include="nimbusml\datasets\_data\train_fs.csv" /> | ||
| <Content Include="nimbusml\datasets\data\gplv2\airquality.csv" /> |
There was a problem hiding this comment.
Why was this renamed? When Stephen and I worked on the docs, the data was always in the _data folder.
There was a problem hiding this comment.
Good catch. I must have missed this because there were no conflicts in nimbusml.pyproj. This is also why the CI run fails (TestPyproj.test_pyproj_existence and TestPyproj.test_pyproj_in - unit tests are passing.
|
The CI run (unit tests) are not passing. Please fix before committing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #314
Update docs to 1.5.0.