This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Yiwzh/fix cv #62
Merged
Yiwzh/fix cv #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add case for X is data frame
add a space
shmoradims
reviewed
Nov 27, 2018
| str(groups) + | ||
| ' cannot be found in the origin data, please specify ' | ||
| 'groups in .fit() function.') | ||
| elif isinstance(X, DataFrame): |
There was a problem hiding this comment.
elif isinstance(X, DataFrame): [](start = 12, length = 30)
please also add a test that covers this new path.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CV, is the training data is a pandas data frame, in the aux_info, there is no information about input data.
In the PR, we update the column existance check to distinguish between cases that input is FileDataStream or pandas dataframe. If the input is pandas data frame, we check if the group id column exists in the dataframe. If the input is FileDataStream, we check if the group id column exists in the FileDataStream's schema.
fixes #58