Refactor traits that allows implementing different engines for the same curve cycle #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinathsetty
commented
Nov 16, 2023
huitseeker
pushed a commit
to huitseeker/Nova
that referenced
this pull request
Nov 22, 2023
…me curve cycle (microsoft#263) * rename Group to Engine * port tests * checkpoint * checkpoint * compiles * update benchmarks and tests to use Engine * rename GroupExt to DlogGroup * move get_curve_params to Group and rename * fix doc test; cargo fmt * inline single trait requirements; fix comments * cut comment
huitseeker
pushed a commit
to huitseeker/Nova
that referenced
this pull request
Nov 22, 2023
…me curve cycle (microsoft#263) * rename Group to Engine * port tests * checkpoint * checkpoint * compiles * update benchmarks and tests to use Engine * rename GroupExt to DlogGroup * move get_curve_params to Group and rename * fix doc test; cargo fmt * inline single trait requirements; fix comments * cut comment
huitseeker
pushed a commit
to huitseeker/Nova
that referenced
this pull request
Nov 22, 2023
…me curve cycle (microsoft#263) * rename Group to Engine * port tests * checkpoint * checkpoint * compiles * update benchmarks and tests to use Engine * rename GroupExt to DlogGroup * move get_curve_params to Group and rename * fix doc test; cargo fmt * inline single trait requirements; fix comments * cut comment
huitseeker
pushed a commit
to huitseeker/Nova
that referenced
this pull request
Nov 22, 2023
…me curve cycle (microsoft#263) * rename Group to Engine * port tests * checkpoint * checkpoint * compiles * update benchmarks and tests to use Engine * rename GroupExt to DlogGroup * move get_curve_params to Group and rename * fix doc test; cargo fmt * inline single trait requirements; fix comments * cut comment
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Nov 27, 2023
* refactor: Refactor `PublicParams` initialization (`new`) to use `setup` method - Updated the function interface for generating `PublicParams` across several files, replacing the `new` method with `setup`. - The method name change impacts the `benches/recursive-snark-supernova.rs`, `src/supernova/test.rs`, and `src/supernova/mod.rs` files. * Refactor traits that allows implementing different engines for the same curve cycle (microsoft#263) * rename Group to Engine * port tests * checkpoint * checkpoint * compiles * update benchmarks and tests to use Engine * rename GroupExt to DlogGroup * move get_curve_params to Group and rename * fix doc test; cargo fmt * inline single trait requirements; fix comments * cut comment --------- Co-authored-by: Srinath Setty <srinath@microsoft.com>
huitseeker
pushed a commit
to huitseeker/Nova
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anchors code around
Enginetrait rather thanGrouptrait so one can build different implementations of theEnginetrait for the same curve cycle.Building on #259, allows customizing
Grouptrait to the particulars of a commitment/evaluation argument.