refactor: remove array for drawn region labels (#542)

microsoft · Sep 4, 2020 · 343ea16 · 343ea16
1 parent 87b6909
commit 343ea16
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/react/components/common/tagInput/tagInputItemLabel.tsx b/src/react/components/common/tagInput/tagInputItemLabel.tsx
@@ -15,12 +15,10 @@ export interface ITagInputItemLabelState {}
 
 export default class TagInputItemLabel extends React.Component<ITagInputItemLabelProps, ITagInputItemLabelState> {
     public render() {
-        const drawnRegions = [];
         const texts = [];
         let hasEmptyTextValue = false;
         this.props.label.value.forEach((formRegion: IFormRegion, idx) => {
-            if (formRegion.text === "" && !hasEmptyTextValue) {
-                drawnRegions.push(<FontIcon className="pr-1 pl-1" iconName="RectangleShape" key={idx}/>)
+            if (formRegion.text === "") {
                 hasEmptyTextValue = true;
             } else {
                 texts.push(formRegion.text);
@@ -35,7 +33,9 @@ export default class TagInputItemLabel extends React.Component<ITagInputItemLabe
             >
                 <div className="flex-center">
                     {text}
-                    {drawnRegions}
+                    {hasEmptyTextValue &&
+                        <FontIcon className="pr-1 pl-1" iconName="RectangleShape"/>
+                    }
                 </div>
             </div>
         );