Stew ro/check tag type and region catagory compatibility #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stew-ro
deleted the
stew-ro/check-tag-type-and-region-catagory-compatibility
branch
stew-ro
restored the
stew-ro/check-tag-type-and-region-catagory-compatibility
branch
stew-ro
changed the base branch from
master
to
alex-krasn/fix-do-not-show-not-compatible-tag-type-changes-#182
alex-krasn
reviewed
May 6, 2020
alex-krasn
approved these changes
May 6, 2020
stew-ro
merged commit c947d74
into
alex-krasn/fix-do-not-show-not-compatible-tag-type-changes-#182
stew-ro
deleted the
stew-ro/check-tag-type-and-region-catagory-compatibility
branch
alex-krasn
added a commit
that referenced
this pull request
May 6, 2020
* fix: we're not allowing change tagtype if it is a checkbox * refactoring: deletes console.log * refactoring: delets comment * + not allow to change tag type to "checkbox" * refactoring: deletes extra brackets * fix: let -> const * fix prev review issues + added warning toast * fix: failing pipeline test * refactoring * refactor: spelling "service" * refactor: switching to is empty(temporary), disabling options instead of removing, updates state on change * refactor: renaming fix test on pipelines * refactor: now with documentCount * style: deletes empty line * refactor: delete 'isEmpty' * style: fix variable to camelcase * refactor * refactor: switching tag types to enum * refactor: switch statement * Stew ro/check tag type and region catagory compatibility (#241) * refactor: check tag type and region catagory compatibility * refactor and spelling Co-authored-by: alex-krasn <v-alexkr@microsoft.com> * feature: no more than one checkbox per tag * refactor: add compatibilty method and refactor * refactor * spelling * style: missing trailing comma * refactor: isCompatible Co-authored-by: stew-ro <60453211+stew-ro@users.noreply.github.com> Co-authored-by: kunzheng <58841788+kunzms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only condition needed is: "selected region equals tag category or tag is free" right?
!this.isSelectionMark(selectedRegions[0].category) && !this.isSelectionMark(tag.type)will become a problem