Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: localization for canvas commandbar items #319 #323

Merged
merged 3 commits into from
Jun 11, 2020
Merged

feature: localization for canvas commandbar items #319 #323

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35780f9
feat: localization all canvas commandbar items
alex-krasn Jun 11, 2020
b38ebe2
fix: labe in Layers - has to be plural
alex-krasn Jun 11, 2020
f2c55ed
style: - extra line
alex-krasn Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/common/localization/en-us.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,32 @@ export const english: IAppStrings = {
title: "Remove All Regions",
confirmation: "Are you sure you want to remove all regions?",
},
canvasCommandBar: {
items: {
layers: {
text: "Layers",
subMenuItems: {
text: "Text",
tables: "Tables",
selectionMarks: "Selection Marks (Preview)",
labels: "Labels"
},
}
},
farItems: {
zoom: {
zoomOut: "Zoom out",
zoomIn: "Zoom in",
},
additionalActions: {
text: "Additional actions",
subIMenuItems: {
runOcrOnCurrentDocument: "Run OCR on current document",
runOcrOnAllDocuments: "Run OCR on all documents",
}
}
}
}
},
messages: {
enforceTaggedRegions: {
Expand Down
26 changes: 26 additions & 0 deletions src/common/localization/es-cl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,32 @@ export const spanish: IAppStrings = {
title: "Borrar Regiones",
confirmation: "¿Está seguro que quiere borrar todas las regiones?",
},
canvasCommandBar: {
items: {
layers:{
text: "Capas",
subMenuItems: {
text: "Texto",
tables: "Tablas",
selectionMarks: "Marcas de selección (vista previa)",
labels: "Etiquetas"
},
}
},
farItems: {
zoom: {
zoomOut: "Alejar",
zoomIn: "Acercarse",
},
additionalActions: {
text: "Acciones adicionales",
subIMenuItems: {
runOcrOnCurrentDocument: "Ejecutar OCR en el documento actual",
runOcrOnAllDocuments: "Ejecute OCR en todos los documentos",
}
}
}
}
},
messages: {
enforceTaggedRegions: {
Expand Down
26 changes: 26 additions & 0 deletions src/common/strings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,32 @@ export interface IAppStrings {
title: string;
confirmation: string;
},
canvasCommandBar: {
items: {
layers: {
text: string,
subMenuItems: {
text: string,
tables: string,
selectionMarks: string;
labels: string,
}
},
},
farItems: {
zoom: {
zoomOut: string,
zoomIn: string,
},
additionalActions: {
text: string,
subIMenuItems: {
runOcrOnCurrentDocument: string,
runOcrOnAllDocuments: string,
}
}
}
},
},
messages: {
enforceTaggedRegions: {
Expand Down
29 changes: 16 additions & 13 deletions src/react/components/pages/editorPage/canvasCommandBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@

stew-ro marked this conversation as resolved.
Show resolved Hide resolved
import * as React from "react";
import { CommandBar, ICommandBarItemProps } from "@fluentui/react/lib/CommandBar";
import { ICustomizations, Customizer } from "@fluentui/react/lib/Utilities";
import { getDarkGreyTheme } from "../../../../common/themes";
import { strings } from '../../../../common/strings';

interface ICanvasCommandBarProps {
handleZoomIn: () => void;
Expand All @@ -23,37 +25,37 @@ export const CanvasCommandBar: React.FunctionComponent<ICanvasCommandBarProps> =
const commandBarItems: ICommandBarItemProps[] = [
{
key: "layers",
text: "Layers",
text: strings.editorPage.canvas.canvasCommandBar.items.layers.text,
iconProps: { iconName: "MapLayers" },
subMenuProps: {
items: [
{
key: "text",
text: "Text",
text: strings.editorPage.canvas.canvasCommandBar.items.layers.subMenuItems.text,
canCheck: true,
iconProps: { iconName: "TextField" },
isChecked: props.layers["text"],
onClick: () => props.handleLayerChange("text"),
},
{
key: "table",
text: "Tables",
text: strings.editorPage.canvas.canvasCommandBar.items.layers.subMenuItems.tables,
canCheck: true,
iconProps: { iconName: "Table" },
isChecked: props.layers["tables"],
onClick: () => props.handleLayerChange("tables"),
},
{
key: "selectionMark",
text: "Selection Marks (Preview)",
text: strings.editorPage.canvas.canvasCommandBar.items.layers.subMenuItems.selectionMarks,
canCheck: true,
iconProps: { iconName: "CheckboxComposite" },
isChecked: props.layers["checkboxes"],
onClick: () => props.handleLayerChange("checkboxes"),
},
{
key: "Label",
text: "Label",
text: strings.editorPage.canvas.canvasCommandBar.items.layers.subMenuItems.labels,
canCheck: true,
iconProps: { iconName: "LabelComposite" },
isChecked: props.layers["label"],
Expand All @@ -67,39 +69,40 @@ export const CanvasCommandBar: React.FunctionComponent<ICanvasCommandBarProps> =
const commandBarFarItems: ICommandBarItemProps[] = [
{
key: "zoomOut",
text: "Zoom out",
text: strings.editorPage.canvas.canvasCommandBar.farItems.zoom.zoomOut,
// This needs an ariaLabel since it's icon-only
ariaLabel: "Zoom out",
ariaLabel: strings.editorPage.canvas.canvasCommandBar.farItems.zoom.zoomOut,
iconOnly: true,
iconProps: { iconName: "ZoomOut" },
onClick: () => props.handleZoomOut(),
},
{
key: "zoomIn",
text: "Zoom in",
text: strings.editorPage.canvas.canvasCommandBar.farItems.zoom.zoomIn,
// This needs an ariaLabel since it's icon-only
ariaLabel: "Zoom in",
ariaLabel: strings.editorPage.canvas.canvasCommandBar.farItems.zoom.zoomIn,
iconOnly: true,
iconProps: { iconName: "ZoomIn" },
onClick: () => props.handleZoomIn(),
},
{
key: "additionalActions",
title: "Additional actions",
ariaLabel: "Additional actions",
title: strings.editorPage.canvas.canvasCommandBar.farItems.additionalActions.text,
// This needs an ariaLabel since it's icon-only
ariaLabel: strings.editorPage.canvas.canvasCommandBar.farItems.additionalActions.text,
className: "additional-action-dropdown",
iconProps: { iconName: "More" },
subMenuProps: {
items: [
{
key: "runOcrForCurrentDocument",
text: "Run OCR on current document",
text: strings.editorPage.canvas.canvasCommandBar.farItems.additionalActions.subIMenuItems.runOcrOnCurrentDocument,
iconProps: { iconName: "TextDocument" },
onClick: () => props.handleRunOcr(),
},
{
key: "runOcrForAllDocuments",
text: "Run OCR for all documents",
text: strings.editorPage.canvas.canvasCommandBar.farItems.additionalActions.subIMenuItems.runOcrOnAllDocuments,
iconProps: { iconName: "Documentation" },
onClick: () => props.handleRunOcrForAllDocuments(),
},
Expand Down