Alex krasn/feature share project #344

alex-krasn · 2020-06-25T15:07:18Z

No description provided.

…into alex-krasn/feature-share-project

stew-ro · 2020-06-30T01:14:48Z

src/assets/sass/fabric-icons-inline.scss

+.ms-Icon--ChromeRestore:before { @include ms-Icon--ChromeRestore }
+.ms-Icon--ChromeMinimize:before { @include ms-Icon--ChromeMinimize }
+.ms-Icon--System:before { @include ms-Icon--System }
+.ms-Icon--SquareShape:before { @include ms-Icon--SquareShape }


can we append to this list instead of replacing it every time. I can't tell what's added or deleted

@stew-ro I thought, you told me that we have to replace this file - when we adding icons.

stew-ro · 2020-06-30T01:16:11Z

src/config/fabric-icons.json

@@ -15,29 +23,21 @@
      "unicode": "EE69"
    },
    {
-      "name": "Table",


Can we append to this instead of replacing/rearranging every time. I can't tell what's being added and deleted

Missing this icon:

If we append instead of replacing/rearranging whole file, catching these errors will be easier

This one is the same, you told me that we have to replace this file. I'll add the missing icon though. What is the name of the missing icon?

src/react/components/common/cloudFilePicker/cloudFilePicker.tsx

stew-ro

Doesn't handle invalid "uri"
2.

It isn't clear that selecting connection and inputting shared project uri are two separate options. I think we should add a separator and two separate headers: "Select connection" ----or---- "Input shared shared project URI"

Was it decided to put the button here? I expected it to be in the project settings.
I think there should be a separator between "share project" and the other items because they're unrelated. Similar to the following:

stew-ro

Share button should be disabled when project connection is of type "localFileSystem"

stew-ro

Need to handle empty azure connections

…into alex-krasn/feature-share-project

stew-ro

Can't access input for Shared project URI

stew-ro

Can't access project share with my configuration still

Not handling invalid input case

stew-ro

stew-ro

Showing a project selected from the connection (not the project shared)

stew-ro · 2020-07-17T06:00:38Z

src/react/components/common/cloudFilePicker/cloudFilePicker.tsx

+                <div className={`shared-string-input-container ${this.state.selectedConnection ? "hide" : ""}`}>
+                    <div className="condensed-list-header bg-darker-2 shared-uri-header">
+                        Shared Project String
+                </div>


src/react/components/common/cloudFilePicker/cloudFilePicker.tsx

stew-ro · 2020-07-17T06:08:40Z

src/react/components/common/cloudFilePicker/cloudFilePicker.tsx

+                    <div className="condensed-list-header bg-darker-2 shared-uri-header">
+                        Shared Project String
+                </div>
+                    {!this.props.connections.length &&


Need to find() if contains cloud projects.

Doesn't show when I have only local connections

stew-ro · 2020-07-17T06:49:22Z

src/react/components/common/cloudFilePicker/cloudFilePicker.tsx

@@ -133,13 +169,58 @@ export class CloudFilePicker extends React.Component<ICloudFilePickerProps, IClo
            const storageProvider = StorageProviderFactory.createFromConnection(this.state.selectedConnection);
            const content = await storageProvider.readText(this.state.selectedFile);
            this.props.onSubmit(content);
+        } else if (this.state.pastedUri && this.getSharedProjectConnectionInfo()) {


Instead of call getSharedProjectConnectionInfo() twice, should assign result as variable

src/react/components/common/cloudFilePicker/cloudFilePicker.tsx

src/redux/actions/projectActions.ts

alex-krasn added 4 commits June 24, 2020 09:50

added share butoon to "Additional actions"

144a7f0

Merge branch 'master' of https://github.com/microsoft/OCR-Form-Tools …

5a141a9

…into alex-krasn/feature-share-project

added sharing functinality

ad09956

Merge branch 'master' of https://github.com/microsoft/OCR-Form-Tools …

07a2eb7

…into alex-krasn/feature-share-project

alex-krasn requested review from tianxiangs and stew-ro June 25, 2020 15:19

alex-krasn added 2 commits June 25, 2020 08:42

runbook and rephrase input placeholder

3ef950f

fix: piplene error - updated package.json and yarn.lock

41878fb

alex-krasn marked this pull request as ready for review June 25, 2020 15:45

fix on pipeline erro r

e50256e

stew-ro reviewed Jun 30, 2020

View reviewed changes

src/react/components/common/cloudFilePicker/cloudFilePicker.tsx Outdated Show resolved Hide resolved

stew-ro reviewed Jun 30, 2020

View reviewed changes

src/react/components/common/cloudFilePicker/cloudFilePicker.tsx Outdated Show resolved Hide resolved

stew-ro reviewed Jun 30, 2020

View reviewed changes

alex-krasn added 11 commits June 30, 2020 09:46

fix: deletes log

4b73a74

input styles in .scss

5cce105

handle string decode error

41fe633

Merge branch 'master' of https://github.com/microsoft/OCR-Form-Tools …

97c2adc

…into alex-krasn/feature-share-project

handle error for no shared connection

639af3c

enable share button only on provider type "azureBlobStorage"

1a44485

strings

0ba830d

feat: devider for commandbar

2973ffc

fix: icons

d56b034

add separator and hidding connetction type when chosen another one

1ffecab

fix: initial state of modal

58ed930

stew-ro reviewed Jul 1, 2020

View reviewed changes

hide separator on connection choice

18d8c07

alex-krasn and others added 5 commits July 3, 2020 08:19

fix: connections check

7aac5bd

fix: check if project in predict page

39a31da

fix: canvas state

3e0c71b

updated: manual

1b6f595

Merge branch 'master' into alex-krasn/feature-share-project

e2a0178

stew-ro reviewed Jul 10, 2020

View reviewed changes

alex-krasn added 5 commits July 10, 2020 10:44

fix: add new URL() in try-catch

da6a8ec

fix: class name affecting some browser's extensions

e8681de

fix: for project tokens with same name

9d2967b

+ string for error message and change color of toast ot red

6f018da

new error message and color

0759d21

alex-krasn linked an issue Jul 13, 2020 that may be closed by this pull request

Share FOTT project by sharing URL to fott file (without SAS token or security token). #298

Closed

stew-ro reviewed Jul 16, 2020

View reviewed changes

alex-krasn added 3 commits July 16, 2020 15:55

Merge branch 'master' into alex-krasn/feature-share-project

9202334

refactor and renaming

1db2192

fix: user shared project name

f803fd9

stew-ro reviewed Jul 17, 2020

View reviewed changes

src/react/components/common/cloudFilePicker/cloudFilePicker.tsx Outdated Show resolved Hide resolved

stew-ro reviewed Jul 17, 2020

View reviewed changes

src/react/components/common/cloudFilePicker/cloudFilePicker.tsx Outdated Show resolved Hide resolved

stew-ro reviewed Jul 17, 2020

View reviewed changes

src/redux/actions/projectActions.ts Show resolved Hide resolved

alex-krasn and others added 4 commits July 17, 2020 08:12

refactor; fix: indents, whitespaces, grammar.

a7ca8f0

add: check if have cloud connections

e696c35

fix: fix grammer for share project message

2dfd9fd

Merge branch 'master' into alex-krasn/feature-share-project

d2fa768

kunzms approved these changes Jul 17, 2020

View reviewed changes

alex-krasn merged commit d059580 into master Jul 17, 2020

alex-krasn deleted the alex-krasn/feature-share-project branch July 17, 2020 22:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alex krasn/feature share project #344

Alex krasn/feature share project #344

alex-krasn commented Jun 25, 2020

stew-ro Jun 30, 2020

alex-krasn Jun 30, 2020

stew-ro Jun 30, 2020

stew-ro Jun 30, 2020

alex-krasn Jun 30, 2020

alex-krasn Jul 1, 2020

stew-ro left a comment •

edited

Loading

stew-ro left a comment

stew-ro left a comment

stew-ro left a comment

stew-ro left a comment •

edited

Loading

stew-ro left a comment

stew-ro left a comment

stew-ro Jul 17, 2020

stew-ro Jul 17, 2020 •

edited

Loading

stew-ro Jul 17, 2020

Alex krasn/feature share project #344

Alex krasn/feature share project #344

Conversation

alex-krasn commented Jun 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stew-ro left a comment • edited Loading

Choose a reason for hiding this comment

stew-ro left a comment

Choose a reason for hiding this comment

stew-ro left a comment

Choose a reason for hiding this comment

stew-ro left a comment

Choose a reason for hiding this comment

stew-ro left a comment • edited Loading

Choose a reason for hiding this comment

stew-ro left a comment

Choose a reason for hiding this comment

stew-ro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stew-ro Jul 17, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stew-ro left a comment •

edited

Loading

stew-ro left a comment •

edited

Loading

stew-ro Jul 17, 2020 •

edited

Loading