Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support model selection #419

Merged
merged 19 commits into from
Jul 17, 2020
Merged

feat: support model selection #419

merged 19 commits into from
Jul 17, 2020

Conversation

stew-ro
Copy link
Contributor

@stew-ro stew-ro commented Jul 16, 2020

No description provided.

@stew-ro stew-ro marked this pull request as ready for review July 16, 2020 10:13
kunzms
kunzms previously approved these changes Jul 16, 2020
View reviewed changes
@stew-ro stew-ro requested review from kunzms and alex-krasn July 16, 2020 17:33
kunzms
kunzms previously approved these changes Jul 16, 2020
View reviewed changes
@alex-krasn
Copy link
Contributor

it fails some accessibility tests:
Screen Shot 2020-07-17 at 12 33 49 PM

@alex-krasn
Copy link
Contributor

Models info/columns in modal not scrollable or responsive on x-axis for narrower windows, so not all model info is accessible
Screen Shot 2020-07-17 at 12 37 13 PM
:

@alex-krasn
Copy link
Contributor

alex-krasn commented Jul 17, 2020 •
edited
Loading

Model list view: now we have unnecessary vertical scrollbar (Safari) and columns still not accessible (have fixed width and not scrollable/resizable)
Screen Shot 2020-07-17 at 1 20 33 PM

@alex-krasn
Copy link
Contributor

The only other thing - is that, I think we should put all messages and titles into localization strings. Not blocking issue, though.

@stew-ro stew-ro force-pushed the stew-ro/support-model-selection-for-analysis branch from 8beddf0 to 8931afd Compare July 17, 2020 21:32
kunzms
kunzms previously approved these changes Jul 17, 2020
View reviewed changes
@stew-ro stew-ro merged commit b4c4cc5 into master Jul 17, 2020
@stew-ro stew-ro deleted the stew-ro/support-model-selection-for-analysis branch July 17, 2020 23:37
@stew-ro stew-ro linked an issue Jul 17, 2020 that may be closed by this pull request
FOTT bug report: Donwload Python code should support 2.0 and 2.1 separately #402
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-krasn alex-krasn alex-krasn approved these changes

@kunzms kunzms kunzms left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FOTT bug report: Donwload Python code should support 2.0 and 2.1 separately
3 participants
@stew-ro @alex-krasn @kunzms