Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove project from app if security token does not exist #468

Merged
merged 13 commits into from
Sep 29, 2020
Merged

feat: remove project from app if security token does not exist #468

merged 13 commits into from
Sep 29, 2020

Conversation

yongbing-chen
Copy link
Contributor

@yongbing-chen yongbing-chen commented Aug 3, 2020 •
edited by alex-krasn
Loading

No description provided.

@yongbing-chen yongbing-chen linked an issue Aug 3, 2020 that may be closed by this pull request
FOTT bug report: if user delete token used by a project, then user can't delete the project #345
Closed
kunzms
kunzms suggested changes Aug 3, 2020
View reviewed changes
src/redux/actions/projectActions.ts Outdated
else {
const decryptedProject = { ...project, sourceConnection };
await projectService.delete(decryptedProject);
dispatch(deleteProjectAction(decryptedProject));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can only remove project from FoTT tool, but make sure we didn't delete the project file, otherwise, someone can delete others project file with this method.

kunzms
kunzms previously approved these changes Aug 4, 2020
View reviewed changes
@kunzms kunzms changed the title Yongbing chen/delete project without token feat: remove project from app if security token does not exist Aug 4, 2020
@yongbing-chen yongbing-chen self-assigned this Aug 7, 2020
@yongbing-chen yongbing-chen removed the request for review from alex-krasn August 17, 2020 09:02
@yongbing-chen yongbing-chen requested a review from stew-ro August 20, 2020 04:23
stew-ro
stew-ro suggested changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@stew-ro stew-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't removing the project from the app for me when I try to open a project from the home page and I don't have a security token

@yongbing-chen yongbing-chen requested a review from stew-ro August 21, 2020 06:44
@yongbing-chen yongbing-chen merged commit 730e196 into master Sep 29, 2020
@yongbing-chen yongbing-chen deleted the yongbing-chen/delete-project-without-token branch September 29, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stew-ro stew-ro stew-ro approved these changes

@kunzms kunzms kunzms left review comments

Assignees

@yongbing-chen yongbing-chen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FOTT bug report: if user delete token used by a project, then user can't delete the project
3 participants
@yongbing-chen @kunzms @stew-ro