Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onnxscript to peephole pass #1530

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Add onnxscript to peephole pass #1530

merged 4 commits into from
Dec 20, 2024

Conversation

xiaoyu-work
Copy link
Contributor

Describe your changes

  • Add onnxscrits to peephole pass
  • Remove self-implemented constant folding.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

jambayk
jambayk previously approved these changes Dec 20, 2024
@jambayk jambayk changed the title Add onnxscrits to peephole pass Add onnxscript to peephole pass Dec 20, 2024
@jambayk jambayk dismissed their stale review December 20, 2024 19:17

Could you also remove the unused helper functions in the test _get_onnx_model_with_constant and _run_onnx_model?

@xiaoyu-work
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xiaoyu-work xiaoyu-work merged commit c631ba2 into main Dec 20, 2024
25 checks passed
@xiaoyu-work xiaoyu-work deleted the xiaoyu/opt branch December 20, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants