Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Aliases or strips namespace prefixes from segment names when and where applicable #369

Merged
merged 18 commits into from
Apr 13, 2023
Merged

[Fix] Aliases or strips namespace prefixes from segment names when and where applicable #369

merged 18 commits into from
Apr 13, 2023

Conversation

irvinesunday
Copy link
Contributor

Fixes #365

This PR:

  • Aliases operation or type cast segments when a namespace alias is available in the model.
  • If the above is not possible, we strip off the namespace prefixes from operation segments when the value of the NamespacePrefixToStripForInMethodPaths matches the namespace of the operation. If these values doesn't match, we don't strip off the namespace.
  • Updates unit tests.
  • Updates release notes.

@irvinesunday irvinesunday requested a review from xuzhg as a code owner April 6, 2023 15:18
@irvinesunday irvinesunday self-assigned this Apr 6, 2023
baywet
baywet previously approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround on this one. I'd like another review from @andrueastman before we merge it.

baywet
baywet previously approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround on this one. I'd like another review from @andrueastman before we merge it.

baywet
baywet previously approved these changes Apr 10, 2023
View reviewed changes
andrueastman
andrueastman previously approved these changes Apr 13, 2023
View reviewed changes
@irvinesunday irvinesunday requested a review from baywet April 13, 2023 11:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.8% 92.8% Coverage
0.0% 0.0% Duplication

baywet
baywet approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for driving this through

@irvinesunday irvinesunday merged commit f9e45d0 into master Apr 13, 2023
@irvinesunday irvinesunday deleted the fix/is/ops-namespace-stripping branch April 13, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman left review comments

@baywet baywet baywet approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees

@irvinesunday irvinesunday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Namespace stripping for functions/actions.
3 participants
@irvinesunday @andrueastman @baywet