Skip to content

[Breaking] Modify validation rules to add CRUD operations #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
irvinesunday merged 12 commits into from
Jul 7, 2023
Merged

[Breaking] Modify validation rules to add CRUD operations #1256

irvinesunday merged 12 commits into from
Jul 7, 2023

Conversation

@irvinesunday
Copy link
Contributor

@irvinesunday irvinesunday commented May 29, 2023 •
edited
Loading

Fixes #1140

This PR:

  • Modifies validation rules to add Create, Read, Update and Delete operations to allow for a configurable experience by clients.
  • Updates and adds relevant tests.
  • This is a breaking change.

@irvinesunday irvinesunday self-assigned this May 29, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems May 29, 2023
View reviewed changes
@baywet
Copy link
Member

baywet commented Jun 7, 2023

@irvinesunday this is conflicting. Would you mind resolving conflicts before we take a look at it please?

baywet
baywet requested changes Jun 14, 2023
View reviewed changes
irvinesunday and others added 3 commits June 19, 2023 10:24
@irvinesunday @baywet
Update src/Microsoft.OpenApi/Validations/ValidationRuleSet.cs
7d18728 
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@irvinesunday @baywet
Update src/Microsoft.OpenApi/Validations/ValidationRuleSet.cs
45ddc20 
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@irvinesunday
Type cast validation rule
3cd3018
baywet
baywet reviewed Jun 19, 2023
View reviewed changes
baywet
baywet requested changes Jun 27, 2023
View reviewed changes
baywet
baywet approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@irvinesunday irvinesunday merged commit 4212ce0 into release/2.0.0 Jul 7, 2023
@irvinesunday irvinesunday deleted the is/validation-rules-CRUD branch July 7, 2023 21:10
@irvinesunday irvinesunday mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@MaggieKimani1 MaggieKimani1 Awaiting requested review from MaggieKimani1

Assignees

@irvinesunday irvinesunday

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@irvinesunday @baywet