Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Hidi --settings-file path to be relative to the current working directory #1481

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Configure Hidi --settings-file path to be relative to the current working directory #1481

merged 2 commits into from
Nov 22, 2023

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1474

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MaggieKimani1 MaggieKimani1 merged commit 9037ca4 into vnext Nov 22, 2023
11 checks passed
@MaggieKimani1 MaggieKimani1 deleted the mk/fix-hidi-relative-path branch November 22, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using relative paths in hidi --settings-path parameter is not relative to the current working directory.
2 participants
@MaggieKimani1 @baywet