Skip to content

Conversation

@PerthCharern
Copy link
Contributor

@PerthCharern PerthCharern commented Dec 18, 2017

  • Output as V3.0.1
  • Recognize any V3.0.X when deserializing

Fix #159


This change is Reviewable

- Recognize any V3.0.X when deserializing
writer.WriteStartObject();

// openapi
writer.WriteProperty(OpenApiConstants.OpenApi, "3.0.0");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it's changed to 3.0.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do have v3.0.1 now.

OpenApi3_0_0
/// Represents all patches of OpenAPI V3.0 spec (e.g. 3.0.0, 3.0.1)
/// </summary>
OpenApi3_0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can not we add new one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A patch should not represent a functional change to the spec. We are expecting to put out patch releases to the spec monthly. We don't want to update this enum on a monthly basis.

@PerthCharern PerthCharern merged commit 96bb3f0 into master Dec 19, 2017
@PerthCharern PerthCharern deleted the PerthCharern/Support3.0.1 branch December 19, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants