Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update-discriminator-mapping #2280

Merged
merged 6 commits into from
Apr 1, 2025
Merged

chore: update-discriminator-mapping #2280

merged 6 commits into from
Apr 1, 2025

Conversation

Michael-Wamae
Copy link
Contributor

  • chore: update-discriminator-mapping

fixes #2140

MaggieKimani1
MaggieKimani1 reviewed Mar 24, 2025
View reviewed changes
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add a test case for when the value in the mapping dictionary is a URI reference pointing to a schema in an external file as in the spec:
image

baywet
baywet approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
78.9% Coverage on New Code (required ≥ 80%)
29.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@baywet baywet merged commit b4877f6 into main Apr 1, 2025
14 of 15 checks passed
@baywet baywet deleted the mw/update-discriminator-mappings branch April 1, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@MaggieKimani1 MaggieKimani1 MaggieKimani1 approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@gavinbarron gavinbarron Awaiting requested review from gavinbarron

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2 - discriminator mappings should be dictionary<string, OpenApiSchemaReference>
3 participants
@Michael-Wamae @baywet @MaggieKimani1