Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verisign curl errors #1516

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Verisign curl errors #1516

merged 1 commit into from
Aug 15, 2022

Conversation

pauld-msft
Copy link
Member

@pauld-msft pauld-msft commented Aug 12, 2022

Fixes the following errors, which occurred every time a github action or lts image is built, adding 1.25 minutes to each image build (adds up when building all images):

#16 [final 2/4] RUN /opt/tmp/images/retry.sh "curl -o /usr/local/share/ca-certificates/verisign.crt -SsL https://crt.sh/?d=1039083 && update-ca-certificates"     && echo "value of DEBIAN_FLAVOR is buster"
#16 sha256:e36fc93fac9f76672954859f38625137fcc21b1850f7d6b75c712c96a6d8d819
#16 0.354 retry 0
#16 0.885 curl: (6) Could not resolve host: &&
#16 5.153 curl: (6) Could not resolve host: update-ca-certificates
#16 5.154 error executing: curl -o /usr/local/share/ca-certificates/verisign.crt -SsL https://crt.sh/?d=1039083 && update-ca-certificates
#16 20.16 retry 1
#16 20.69 curl: (6) Could not resolve host: &&
#16 24.96 curl: (6) Could not resolve host: update-ca-certificates
#16 24.96 error executing: curl -o /usr/local/share/ca-certificates/verisign.crt -SsL https://crt.sh/?d=1039083 && update-ca-certificates
#16 39.97 retry 2
#16 40.51 curl: (6) Could not resolve host: &&
#16 44.58 curl: (6) Could not resolve host: update-ca-certificates
#16 44.58 error executing: curl -o /usr/local/share/ca-certificates/verisign.crt -SsL https://crt.sh/?d=1039083 && update-ca-certificates
#16 59.59 retry 3
#16 60.11 curl: (6) Could not resolve host: &&
#16 64.39 curl: (6) Could not resolve host: update-ca-certificates
#16 64.39 error executing: curl -o /usr/local/share/ca-certificates/verisign.crt -SsL https://crt.sh/?d=1039083 && update-ca-certificates
#16 79.40 retry 4
#16 79.94 curl: (6) Could not resolve host: &&
#16 84.01 curl: (6) Could not resolve host: update-ca-certificates
#16 84.01 error executing: curl -o /usr/local/share/ca-certificates/verisign.crt -SsL https://crt.sh/?d=1039083 && update-ca-certificates
#16 99.02 retry 5
#16 99.58 curl: (6) Could not resolve host: &&
#16 103.8 curl: (6) Could not resolve host: update-ca-certificates
#16 103.9 error executing: curl -o /usr/local/share/ca-certificates/verisign.crt -SsL https://crt.sh/?d=1039083 && update-ca-certificates
#16 118.9 value of DEBIAN_FLAVOR is buster
#16 DONE 118.9s

I also investigated whether we really need this (since its been broken for a while), and I think we would be safe to remove if we want.

It was an issue prior to the following versions of .NET that prevented restores:
.NET SDK 5.0.202 -- April 6, 2021.
.NET 6 Preview 3 -- April 8, 2021.

According to NuGet/Announcements#49 this has been resolved with an updated version of ca-certificates
Link to full context of issue: NuGet/Home#10491

Let me know what you all think should be the correct move here. It seems to me like pulling and trusting an external cert from the internet seems risky.

@pauld-msft pauld-msft requested a review from a team as a code owner August 12, 2022 19:05
@pauld-msft
Copy link
Member Author

Fixed log looks like

#16 [final 2/4] RUN /opt/tmp/images/retry.sh "curl -o /usr/local/share/ca-certificates/verisign.crt -SsL https://crt.sh/?d=1039083"     && update-ca-certificates     && echo "value of DEBIAN_FLAVOR is buster"
#16 sha256:d0b82b32b8ff5ba252405ee88dd7f98f902c083d97b401bda6723810a267e93d
#16 0.369 retry 0
#16 0.924 Updating certificates in /etc/ssl/certs...
#16 1.709 rehash: warning: skipping duplicate certificate in verisign.pem
#16 1.711 1 added, 0 removed; done.
#16 1.711 Running hooks in /etc/ca-certificates/update.d...
#16 1.716 done.
#16 1.719 value of DEBIAN_FLAVOR is buster
#16 DONE 1.7s

Copy link
Contributor

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :shipit:

@pauld-msft pauld-msft merged commit b4dcd11 into main Aug 15, 2022
@pauld-msft pauld-msft deleted the pauld/fix-ca-certificates-upgrade branch August 15, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants