Supporting running FastAPI apps via Uvicorn in Python runtimes #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryli0108
approved these changes
Nov 15, 2023
william-msft
approved these changes
Nov 16, 2023
daniv-msft
reviewed
Nov 16, 2023
| @@ -81,6 +81,7 @@ LABEL io.buildpacks.stack.id="oryx.stacks.skeleton" | |||
| RUN ${IMAGES_DIR}/runtime/python/install-dependencies.sh | |||
| RUN pip install --upgrade pip \ | |||
| && pip install gunicorn \ | |||
| && pip install uvicorn \ | |||
There was a problem hiding this comment.
Unfortunately, I don't think we can add these for the existing images as it can have some implications in terms of size and side-effects for existing customers.
The easiest ways I would see is:
- Waiting for a new Python version and only enable this here.
- Create a new image just for this case, which is a bit annoying as well.
We can sync offline if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for detecting and running applications targeting the FastAPI Python framework. Rather than using the traditional Gunicorn server for running the application, we are now supporting Uvicorn as the server of choice for FastAPI applications.