Fix for missing default settings at startup. #8172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
reviewed
Feb 14, 2025
| context = _clientContexts.Find(c => c.RootPath == null); | ||
| if (context == null) { | ||
| return null; | ||
| // use first clientcontext as default | ||
| context = _clientContexts.First(); |
There was a problem hiding this comment.
Is there a FirstOrNull thing? I wasn't sure if this would throw if there's no items in the list.
There was a problem hiding this comment.
Oh it's called 'FirstOrDefault'. Maybe you should use that?
There was a problem hiding this comment.
i check count at the top of the function. but ya. that would be safer
debonte
previously approved these changes
Feb 14, 2025
rchiodo
previously approved these changes
Feb 14, 2025
guard against no context elements on shutdown. A context is created for the project or for each workspace or for each repl.
bschnurr
force-pushed
the
fix-tasklist
branch
from
5eefffc to
adb386e
Compare
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guard against no context elements on shutdown. A context is created for the project or for each workspace or for each repl.
We need to send tasklist info when sending default settings with "workspace/didChangeConfiguration".
alternatively we could pass in the uri into GetSettings() when "TriggerWorkspaceUpdateConfig" is called.
Fix for #8121