Removing TODOs (#282)

* removing TODOs * remove unittest todo
microsoft · Jul 27, 2023 · b4ff416 · b4ff416
1 parent bcc2335
commit b4ff416
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/src/Microsoft.PowerApps.TestEngine.Tests/PowerFx/PowerFxHelperTests.cs b/src/Microsoft.PowerApps.TestEngine.Tests/PowerFx/PowerFxHelperTests.cs
@@ -73,8 +73,6 @@ public void TestFormulasSeparatedByChainingOpAreExtractedCorrectly(string locale
 
  private static Engine GetEngine(string locale)
  {
- //TODO: Temporarily removed the locale input parameter from PowerFxConfig(...), make sure to add it back
- //var recalcEngine = new RecalcEngine(new PowerFxConfig(new CultureInfo(locale)));
  var recalcEngine = new RecalcEngine(new PowerFxConfig());
  return recalcEngine;
  }

diff --git a/src/Microsoft.PowerApps.TestEngine/PowerApps/PowerAppFunctions.cs b/src/Microsoft.PowerApps.TestEngine/PowerApps/PowerAppFunctions.cs
@@ -254,7 +254,7 @@ public async Task<bool> SetPropertyAsync(ItemPath itemPath, FormulaValue value)
  }
 
  ValidateItemPath(itemPath, false);
- // TODO: handle components
+
  var expression = $"PowerAppsTestEngine.setPropertyValue({JsonConvert.SerializeObject(itemPath)}, {JsonConvert.SerializeObject(objectValue)})";
  return await _testInfraFunctions.RunJavascriptAsync<bool>(expression);
  }

diff --git a/src/Microsoft.PowerApps.TestEngine/PowerFx/Functions/WaitFunction.cs b/src/Microsoft.PowerApps.TestEngine/PowerFx/Functions/WaitFunction.cs
@@ -11,7 +11,6 @@ namespace Microsoft.PowerApps.TestEngine.PowerFx.Functions
 {
  /// <summary>
  /// This will wait for the property of the control to equal the specified value.
- /// TODO: Future intended function is of this format: `Wait(boolean expression)`. This is pending some improvements in Power FX to be available.
  /// </summary>
  public class WaitFunction : ReflectionFunction
  {