Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade PowerFx.Interpreter library to 0.2.6-preview #280

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Upgrade PowerFx.Interpreter library to 0.2.6-preview #280

merged 8 commits into from
Jul 19, 2023

Conversation

arpavan
Copy link
Contributor

@arpavan arpavan commented Jul 18, 2023

Description

This PR upgrades the version of Microsoft.PowerFx.Interpreter to 0.2.6-preview, and addresses any compile time and breaking changes and also updates tests associated with this upgrade.

Checklist

  • The code change is covered by unit tests. I have added tests that prove my fix is effective or that my feature works
  • I have performed end-to-end test locally.
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I used clear names for everything
  • I have performed a self-review of my own code

arpavan and others added 8 commits July 14, 2023 10:17
@arpavan
updated sample for calculator/testPlanWithCommaForDecimal.fx.yaml to …
2177874 
…use a different app
@arpavan
Merge branch 'main' of https://github.com/microsoft/PowerApps-TestEngine
b0c356c
@arpavan
upgraded PowerFx.Interpreter Microsoft.PowerFx.Interpreter to 0.2.6-p…
1cb8f6d 
…review
@arpavan
Refactor DateValue field and fix other compile time errors (#275)
bd0e735 
* refactored all references of DateValue.Value to DateValue.GetConvertedValue(null)

* changed DateValue.Value to DateValue.GetConvertedValue(null)

* Updated implementation of IUntypedObject

* temporarily removed locale from PowerFxConfig constructor to unblock other fixes

---------

Co-authored-by: Pavan Agnihotri <1485950+arpavan@users.noreply.github.com>
@NavneetThekkumpat @arpavan
Support localization with updated PowerFx version (#276)
42f9fcd 
* supporting locale
@NavneetThekkumpat @arpavan
Handling setProperty invalid argument type error when value is number (…
4999db0 
…#278)

* setting numberisfloat config to true

* commenting

* commenting

* refactoring

* refactoring
@arpavan
updated sample for calculator/testPlanWithCommaForDecimal.fx.yaml
342b6e6
@arpavan
fixed PowerFxEngineTests after rebasing
5e81495
@arpavan arpavan requested a review from a team as a code owner July 18, 2023 21:59
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Microsoft.PowerApps.TestEngine 91% 88% 925 ✔
Summary 91% (2457 / 2686) 88% (559 / 636) 925 ✔

Minimum allowed line rate is 85%

@arpavan arpavan merged commit 38fc325 into main Jul 19, 2023
9 checks passed
@arpavan arpavan deleted the users/arpavan/upgrade-to-powerfx-0.2.6-preview branch July 19, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NavneetThekkumpat NavneetThekkumpat NavneetThekkumpat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpavan @NavneetThekkumpat