Handle Invalid Output Directory #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NavneetThekkumpat
approved these changes
Aug 23, 2023
NavneetThekkumpat
approved these changes
Aug 23, 2023
Minimum allowed line rate is |
| @@ -178,7 +178,11 @@ | |||
|
|
|||
| //setting defaults for optional parameters outside RunTestAsync | |||
| var testResult = await testEngine.RunTestAsync(testPlanFile, environmentId, tenantId, outputDirectory, domain, queryParams); | |||
| Console.WriteLine($"Test results can be found here: {testResult}"); | |||
| if (testResult != "InvalidOutputDirectory") | |||
There was a problem hiding this comment.
In PAC CLI >> when we update the TE version with this fix included, reminder to make this change there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If output directory exists but is invalid, such as a drive doesn't exist, handle this properly so this doesn't throw an unknown error up the chain.
Checklist