Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Invalid Output Directory #303

Merged
merged 12 commits into from
Aug 24, 2023

Conversation

landonmsft
Copy link
Contributor

Description

If output directory exists but is invalid, such as a drive doesn't exist, handle this properly so this doesn't throw an unknown error up the chain.

Checklist

  • The code change is covered by unit tests. I have added tests that prove my fix is effective or that my feature works
  • I have performed end-to-end test locally.
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I used clear names for everything
  • I have performed a self-review of my own code

@landonmsft landonmsft self-assigned this Aug 23, 2023
@landonmsft landonmsft requested a review from a team as a code owner August 23, 2023 17:09
@landonmsft landonmsft marked this pull request as draft August 23, 2023 19:57
@landonmsft landonmsft marked this pull request as ready for review August 23, 2023 20:40
Copy link
Contributor

@NavneetThekkumpat NavneetThekkumpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add back the unittest in consoleoutputtest.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Microsoft.PowerApps.TestEngine 91% 87% 982
Summary 91% (2541 / 2792) 87% (598 / 684) 982

Minimum allowed line rate is 85%

@@ -178,7 +178,11 @@

//setting defaults for optional parameters outside RunTestAsync
var testResult = await testEngine.RunTestAsync(testPlanFile, environmentId, tenantId, outputDirectory, domain, queryParams);
Console.WriteLine($"Test results can be found here: {testResult}");
if (testResult != "InvalidOutputDirectory")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PAC CLI >> when we update the TE version with this fix included, reminder to make this change there.

@landonmsft landonmsft merged commit 42ffd31 into main Aug 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants