Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented PAC validation #459

Merged
merged 50 commits into from
Aug 22, 2023
Merged

Implemented PAC validation #459

merged 50 commits into from
Aug 22, 2023

Conversation

AleksSavelev
Copy link
Contributor

No description provided.

@AleksSavelev AleksSavelev requested a review from uve April 25, 2023 14:47
@iMicknl iMicknl mentioned this pull request May 6, 2023
Closed
uve
uve reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@uve uve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. make functions decompositions
  2. move to TypeScipt
  3. Generate Custom exceptions
  4. use pipe style
  5. Improve naming
  6. Splint validation logic between multiple small files.

bin/pbiviz-package.js Outdated Show resolved Hide resolved
bin/pbiviz-package.js Outdated Show resolved Hide resolved
lib/VisualFeaturesPrecheck.js Outdated Show resolved Hide resolved
bin/pbiviz-package.js Outdated Show resolved Hide resolved
bin/pbiviz-package.js Outdated Show resolved Hide resolved
bin/pbiviz-package.js Outdated Show resolved Hide resolved
lib/ConsoleWriter.js Outdated Show resolved Hide resolved
lib/VisualFeaturesPrecheck.js Outdated Show resolved Hide resolved
uve

This comment was marked as duplicate.

Sign in to view

uve
uve reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@uve uve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. make functions decompositions
  2. move to TypeScipt
  3. Generate Custom exceptions
  4. use pipe style
  5. Improve naming
  6. Splint validation logic between multiple small files.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 12, 2023
View reviewed changes
lib/ConsoleWriter.js Fixed Show fixed Hide fixed
src/ConsoleWriter.ts Dismissed Show dismissed Hide dismissed
src/CertificateTools.ts Fixed Show fixed Hide fixed
src/CertificateTools.ts Fixed Show fixed Hide fixed
AleksSavelev added a commit to AleksSavelev/PowerBI-visuals-tools that referenced this pull request Jun 27, 2023
@AleksSavelev
Changes from PR microsoft#459
55d59c5
AleksSavelev added a commit to AleksSavelev/PowerBI-visuals-tools that referenced this pull request Jun 27, 2023
@AleksSavelev
Changes from PR microsoft#459
f1837cf
@AleksSavelev
Copy link
Contributor Author

AleksSavelev commented Jul 3, 2023 •
edited
Loading

uve
uve requested changes Jul 20, 2023
View reviewed changes
src/FeatureManager.ts Outdated Show resolved Hide resolved
src/Package.ts Outdated Show resolved Hide resolved
src/Package.ts Outdated Show resolved Hide resolved
src/FeatureManager.ts Outdated Show resolved Hide resolved
src/features/BaseFeature.ts Outdated Show resolved Hide resolved
src/features/ColorPalette.ts Outdated Show resolved Hide resolved
src/features/FeatureTypes.ts Outdated Show resolved Hide resolved
src/features/FeatureTypes.ts Outdated Show resolved Hide resolved
src/Package.ts Outdated Show resolved Hide resolved
@AleksSavelev AleksSavelev merged commit 29075f2 into microsoft:main Aug 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uve uve uve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AleksSavelev @uve