File Actions menu #31220
File Actions menu #31220
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| </ui:MenuItem.Icon> | ||
| </ui:MenuItem> | ||
| <Separator/> | ||
| <ui:MenuItem Header="Copy path of files sperated by"> |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
|
@niels9001 Do you have an idea why the contextmenu doesn't take the WPFUI style? |
… to replace filename with hash
There was a problem hiding this comment.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This comment has been minimized.
This comment has been minimized.
…/microsoft/PowerToys into dev/aaron-junker/FileActionsMenu
|
Thanks for the fix Aaron, I'll give it a try today and do another round of review |
|
Is this planned to get in for 0.88 release? |
There was a problem hiding this comment.
I fixed the installer, now everything works.
I left few comments and issues to resolve.
Also, it would be good to put all of the FileActionsMenu DLLs to single out dir (I'd say WinUI3Apps if UI app is winui3) .. because now , some stuff goes to root output dir and some to WinUI3Apps dir. This ends up with helpers and intefraces DLLs being duplicated and installed to both which we don't want.
| @@ -353,3 +353,6 @@ src/common/Telemetry/*.etl | |||
|
|
|||
| # MSBuildCache | |||
| /MSBuildCacheLogs/ | |||
|
|
|||
| # Temp telemetry files. | |||
| *.etl | |||
There was a problem hiding this comment.
why is this here? where do you see .etl files inside the repo? This shouldn't happen
There was a problem hiding this comment.
When following the instructions in https://github.com/microsoft/PowerToys/tree/main/src/common/Telemetry to look at sent telemetry it produces an etl file.
Co-authored-by: Stefan Markovic <57057282+stefansjfw@users.noreply.github.com>
…/microsoft/PowerToys into dev/aaron-junker/FileActionsMenu
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
…/microsoft/PowerToys into dev/aaron-junker/FileActionsMenu
…/microsoft/PowerToys into dev/aaron-junker/FileActionsMenu
…/microsoft/PowerToys into dev/aaron-junker/FileActionsMenu
|
@stefansjfw All your comments are now adressed |
Summary of the Pull Request
Adding a new menu invokable by selecting files in explorer and pressing a shortcut set in the settings.
Screenshots
PR Checklist
Detailed Description of the Pull Request / Additional comments
Things left to do:
Validation Steps Performed