Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peek support for ipynb(jupyter notebook) #33434

Open
ohhh-yang opened this issue Jun 19, 2024 · 13 comments
Open

Peek support for ipynb(jupyter notebook) #33434

ohhh-yang opened this issue Jun 19, 2024 · 13 comments
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Product-Peek Refers to Peek Powertoys

Comments

@ohhh-yang
Copy link

Description of the new feature / enhancement

Peek should support more file format, such as ipynb(jupyter notebook)

Scenario when this would be used?

Peek does not support many file format, it shoudn't be.

Supporting information

No response

@ohhh-yang ohhh-yang added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jun 19, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@ohhh-yang
Copy link
Author

ohhh-yang commented Jun 19, 2024 via email

@crutkas crutkas changed the title Peek should support more file format, such as ipynb(jupyter notebook) Peek support for ipynb(jupyter notebook) Jun 27, 2024
@crutkas crutkas added Help Wanted We encourage anyone to jump in on these and submit a PR. Product-Peek Refers to Peek Powertoys and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jun 27, 2024
@github-project-automation github-project-automation bot moved this to ⚠️Needs Walkthrough in 3. Help Wanted Jun 27, 2024
@htcfreek
Copy link
Collaborator

@Paulinho00
Your contribution is welcome and thank you for your work on this. Feel free to open a PR. If you have any further questions don't worry to ask them.

@htcfreek htcfreek added the Status-In progress This issue or work-item is under development label Jun 28, 2024
@Paulinho00
Copy link

Paulinho00 commented Jun 28, 2024

I investigated it a bit and I've not found a way to display a notebook as it is shown e.g. in VSC (with cells and output formatting). I considered converting notebook to already supported file extensions (e.g. html or markdown), but there is no easy way of doing it. It basically would require writing our converter. I also considered displaying notebook as json but I'm not sure about it, because it is not very readable and probably it wasn't what notebook users expects. Do you have any idea how can it be displayed?

@htcfreek
Copy link
Collaborator

@Paulinho00
Sory I can't help here. I never used this files in my computer life yet.

@Paulinho00
Copy link

How to debug Peek? Is there any way to debug without building installer etc. ?

@htcfreek
Copy link
Collaborator

How to debug Peek? Is there any way to debug without building installer etc. ?

cc: @davidegiacometti , @jaimecbernardo

@jaimecbernardo
Copy link
Collaborator

It's possible to build all projects from Visual Studio and start from the runner.
The Runner starts the Peek process and then you can attach a debugger to it.
I also use this plugin for some of these scenarios so that a debugger is automatically attached to new processes created by processes we are debugging: https://marketplace.visualstudio.com/items?itemName=vsdbgplat.MicrosoftChildProcessDebuggingPowerTool2022

@Paulinho00
Copy link

Paulinho00 commented Jul 1, 2024

Do you know why I get Failed to load PowerToys.FindMyMouse.dll and a couple more similar looking errors immediately after the build process is completed? I build solution step by step as prescribed in guidelines. Here is example call stack

KernelBase.dll!00007ffc1a99f39c() Unknown
PowerToys.exe!CxxThrowException(void * pExceptionObject, const s__ThrowInfo * pThrowInfo) Line 81 C++
PowerToys.exe!winrt::throw_hresult(const winrt::hresult result, const std::source_location & sourceInformation) Line 5163 C++
PowerToys.exe!winrt::throw_last_error(const std::source_location & sourceInformation) Line 5226 C++
PowerToys.exe!winrt::check_pointer<HINSTANCE
>(HINSTANCE__ * pointer, const std::source_location & sourceInformation) Line 5272 C++
PowerToys.exe!load_powertoy(const std::basic_string_view<wchar_t,std::char_traits<wchar_t>> filename) Line 16 C++
PowerToys.exe!runner(bool isProcessElevated, bool openSettings, std::string settingsWindow, bool openOobe, bool openScoobe, bool showRestartNotificationAfterUpdate) Line 175 C++
PowerToys.exe!WinMain(HINSTANCE__ * formal, HINSTANCE * __formal, char * lpCmdLine, int __formal) Line 452 C++
PowerToys.exe!invoke_main() Line 107 C++
PowerToys.exe!__scrt_common_main_seh() Line 288 C++
PowerToys.exe!__scrt_common_main() Line 331 C++
PowerToys.exe!WinMainCRTStartup(void * __formal) Line 17 C++
kernel32.dll!00007ffc1b3d257d() Unknown
ntdll.dll!00007ffc1d00af28() Unknown

@htcfreek
Copy link
Collaborator

@Paulinho00
Are you still working on this? (@asif4318 is asking if he can work on this.)

@asif4318
Copy link

Is the goal to have it displayed in the editor formatted with cells & markdown?
.ipynb are just JSON files internally

Posted some screenshots to clarify.

Image

Image

@Paulinho00
Copy link

@htcfreek No, I'm not.

@htcfreek htcfreek removed the Status-In progress This issue or work-item is under development label Dec 26, 2024
@htcfreek
Copy link
Collaborator

@asif4318
I personally think the notebook view makes most sense if possible. Because that the use case of this format. What do you think @crutkas ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Product-Peek Refers to Peek Powertoys
Projects
Status: ⚠️Needs Walkthrough
Development

No branches or pull requests

6 participants