Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New+ Windows 10 support #35832

Merged
merged 31 commits into from
Nov 27, 2024
Merged

New+ Windows 10 support #35832

merged 31 commits into from
Nov 27, 2024

Conversation

cgaarden
Copy link
Contributor

@cgaarden cgaarden commented Nov 8, 2024 •
edited
Loading

Summary of the Pull Request

This PR provides New+ support for Windows 10.

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • Added Windows 10 support, without breaking Windows 11 support

Validation Steps Performed

Windows 10

  1. Installed on clean Windows 10 Home version (en_US)
  2. (test-signing is not needed)
  3. Desktop: Icon view: Tier 1 context menu New+ folder and files
  4. In folder on Desktop: Detailed view: Tier 1 context menu New+ folder and files
  5. Reviewed logs in NewPlus.ShellExtension\Logs\v0.0.1

Windows 11

  1. Installed on clean Windows 11 Sandbox (en_US)
  2. Manually test-signed
  3. Desktop: Icon view: Tier 1 context menu New+ folder and files
  4. In folder on Desktop: Detailed view: Tier 1 context menu New+ folder and files
  5. Reviewed logs in NewPlus.ShellExtension\Logs\v0.0.1

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@cgaarden cgaarden marked this pull request as ready for review November 10, 2024 04:23
@cgaarden cgaarden changed the title Windows 10 experimental support New+ Windows 10 support Nov 10, 2024
@stefansjfw stefansjfw mentioned this pull request Nov 12, 2024
Open
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@jaimecbernardo
Copy link
Collaborator

Thank you for opening this PR. Right now fixing some stuff so I can get builds out of Dart CI to test, so I'll be pushing some commits 😄

@jaimecbernardo
Copy link
Collaborator

Currently trying to reduce telemetry calls, as I see one gets generated everytime I right-click on Desktop / any explorer window. Trying to reduce those ;)

@crutkas crutkas added Needs-Review This Pull Request awaits the review of a maintainer. in for .87 labels Nov 26, 2024
jaimecbernardo
jaimecbernardo approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks a lot for the contribution 😄

@jaimecbernardo jaimecbernardo added Good to Merge and removed Needs-Review This Pull Request awaits the review of a maintainer. labels Nov 27, 2024
@jaimecbernardo jaimecbernardo merged commit 084402a into microsoft:main Nov 27, 2024
16 checks passed
@cgaarden
Copy link
Contributor Author

@jaimecbernardo - Thanks a bunch for fixing my remaining bugs here Jaime!

cgaarden added a commit to cgaarden/PowerToys that referenced this pull request Nov 29, 2024
@cgaarden
Squashed commit of the following:
d8df2aa 
commit a50eb4a
Author: Christian Gaarden Gaardmark <cgaarden@hotmail.com>
Date:   Thu Nov 28 21:41:29 2024 -0800

    Remove a small change

commit 587320d
Author: Christian Gaarden Gaardmark <cgaarden@hotmail.com>
Date:   Thu Nov 28 09:45:46 2024 -0800

    Fix for enter_rename mode

commit 911864e
Author: Christian Gaarden Gaardmark <cgaarden@hotmail.com>
Date:   Thu Nov 28 07:53:01 2024 -0800

    Early version -- doesn't work

commit 3dc4913
Author: Shuai Yuan <128874481+shuaiyuanxx@users.noreply.github.com>
Date:   Thu Nov 28 05:57:20 2024 +0800

    Upgrade Windows App SDK to the latest version (microsoft#36093)

    Signed-off-by: Shawn Yuan <shuai.yuan.zju@gmail.com>

commit 271d64b
Author: grzhan <envy518@gmail.com>
Date:   Thu Nov 28 03:44:56 2024 +0800

    [PTRun][Docs] Add HttpStatusCodes to Third-Party plugins (microsoft#36055)

    * [PTRun][Docs] Add HttpStatusCodes to Third-Party plugins

    * adding grzhan to names.txt

    ---------

    Co-authored-by: Clint Rutkas <clint@rutkas.com>

commit a90b646
Author: Andrea Bartolucci <andrea-barto@hotmail.com>
Date:   Wed Nov 27 18:30:25 2024 +0100

    [PTRun][WindowWalker]Added score to the results (microsoft#35691)

    Added Score to the results returned by WindowWalker

    Co-authored-by: Andrea Bartolucci <8514491+andbartol@users.noreply.github.com>

commit 084402a
Author: Christian Gaarden Gaardmark <cgaarden@hotmail.com>
Date:   Wed Nov 27 06:22:05 2024 -0800

    [New+]Windows 10 support (microsoft#35832)

commit 08fe808
Author: Ani <115020168+drawbyperpetual@users.noreply.github.com>
Date:   Tue Nov 26 21:38:41 2024 +0100

    [Logs]Fixed name of logging method in managed logging (microsoft#35952)

    * Fixed name of method in managed logging

    * Added hardening

commit 5321218
Author: Michael Clayton <mike@kingslandconsulting.co.uk>
Date:   Tue Nov 26 15:37:59 2024 +0000

    [Mouse Jump] Customisable appearance - borders, margins, colours, etc - final part (microsoft#35521)

    * [MouseJump] move Mouse Jump settings into separate control (microsoft#27511)

    * [MouseJump] added Mouse Jump style controls to Settings UI (microsoft#27511)

    * [MouseJump] added Mouse Jump style controls to Settings UI (microsoft#27511)

    * [MouseJump] removing unused MouseJumpUI code (microsoft#27511)

    * [MouseJump] whitespace (microsoft#27511)

    * [MouseJump] fix spellcheck (microsoft#27511)

    * [MouseJump] enabled "Copy to custom style" (microsoft#27511)

    * [MouseJump] fixing build (internal members -> public) (microsoft#27511)

    * [MouseJump] remove unused "using"s (microsoft#27511)

    * [MouseJump] use custom styles in preview image (microsoft#27511)

    * [MouseJump] fixing failing test (microsoft#27511)

    * [MouseJump] fixing failing test (microsoft#27511)

    * [MouseJump] fixing failing test (microsoft#27511)

    * [MouseJump] fixing failing test (microsoft#27511)

    * [MouseJump] delinting to trigger a build (microsoft#27511)

    * [MouseJump] updated settings preview image ("browser" header) (microsoft#27511)

    * [MouseJump] upgrade default "custom" style settings in config (microsoft#27511)

    * [MouseJump] fixed a glitch in settings upgrade (microsoft#27511)

    * [MouseJump] fixed spell checker (microsoft#27511)

    * [MouseJump] typo in resource strings (image -> images) (microsoft#27511)

    * Remove unused include

commit 7c98765
Author: Ishita Agarwal <32492187+agarwalishita@users.noreply.github.com>
Date:   Tue Nov 26 10:43:44 2024 +0530

    Removed extra space from welcome page (microsoft#35778)

    * Removed extra space from welcome page

    * Added space between info bar and release notes

commit 6cece12
Author: Dave Rayment <dave.rayment@gmail.com>
Date:   Fri Nov 22 16:25:01 2024 +0000

    [Peek]Add support for previewing .ahk files as plaintext (microsoft#35538)

commit 863f7aa
Author: Dave Rayment <dave.rayment@gmail.com>
Date:   Fri Nov 22 16:24:15 2024 +0000

    [Peek] Fix Monaco assets folder discovery (microsoft#35925)

commit b81478e
Author: Dave Rayment <dave.rayment@gmail.com>
Date:   Fri Nov 22 14:49:35 2024 +0000

    [Peek]Expand image format support for Image Previewer using local capabilities (microsoft#35622)

    * Use BitmapDecoder to query compatible file extensions.

    * Delete spellcheck exceptions for removed file types

    * Remove unused usings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crutkas crutkas crutkas approved these changes

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

@DHowett DHowett Awaiting requested review from DHowett

@ethanfangg ethanfangg Awaiting requested review from ethanfangg

Assignees
No one assigned
Labels
Good to Merge
Projects
5. Needs Attention
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgaarden @jaimecbernardo @crutkas