Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Area-Build] Fix build for VS 16.10 #11557

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

mykhailopylyp
Copy link
Contributor

Summary of the Pull Request

What is this about:
After updating to VS 16.10 KBM module fails to build.
There are two issues:

  • int can't be implicitly converted to DWORD. I'm not sure what is the reason behind it as both are 32-bit integers
  • There are issues with initializing RemapBufferItem({ 0x41, 0x42 }. It produces an empty vector. I guess it's going to be fixed soon but we need to fix it to unblock master.

What is include in the PR:

How does someone test / validate:

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@mykhailopylyp mykhailopylyp added the Area-Build Issues pertaining to the build system, CI, infrastructure, meta label Jun 1, 2021
@mykhailopylyp mykhailopylyp merged commit 3b32116 into microsoft:master Jun 1, 2021
@mykhailopylyp mykhailopylyp deleted the issue-11545 branch June 1, 2021 16:15
@TobiasSekan
Copy link
Contributor

* `int` can't be implicitly converted to `DWORD`. I'm not sure what is the reason behind it as both are 32-bit integers

I'm not sure, but i think
DWORD is always a 32-bit on Windows and int is platform specific (16-bit or 32-bit)

https://docs.microsoft.com/en-us/windows/win32/winprog/windows-data-types says

A 32-bit unsigned integer. The range is 0 through 4294967295 decimal.
This type is declared in IntSafe.h as follows:
typedef unsigned long DWORD;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants