Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal build #11668

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Fix internal build #11668

merged 1 commit into from
Jun 8, 2021

Conversation

mykhailopylyp
Copy link
Contributor

Summary of the Pull Request

What is this about:

What is include in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: #xxx
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@mykhailopylyp mykhailopylyp added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Run-Plugin Things that relate with PowerToys Run's plugin interface labels Jun 8, 2021
@mykhailopylyp mykhailopylyp requested a review from crutkas June 8, 2021 19:02
@crutkas
Copy link
Member

crutkas commented Jun 8, 2021

i'd suggest commenting it out personally.

@crutkas
Copy link
Member

crutkas commented Jun 8, 2021

worked.

@crutkas crutkas merged commit 3e5c757 into master Jun 8, 2021
@crutkas crutkas deleted the dev/mykhailopylyp/internal-build branch June 8, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crutkas crutkas Awaiting requested review from crutkas

Assignees
No one assigned
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mykhailopylyp @crutkas