Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FancyZones] Avoid unnecessary calculations when selecting a zone #11815

Merged
merged 2 commits into from
Jun 22, 2021
Merged

[FancyZones] Avoid unnecessary calculations when selecting a zone #11815

merged 2 commits into from
Jun 22, 2021

Conversation

SeraphimaZykova
Copy link
Collaborator

Summary of the Pull Request

What is this about:

Moved calculations that are pointless when the other than "ClosestCenter" algorithm is selected.

What is include in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: #xxx
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@SeraphimaZykova SeraphimaZykova added the Product-FancyZones Refers to the FancyZones PowerToy label Jun 21, 2021
yuyoyuppe
yuyoyuppe approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@yuyoyuppe yuyoyuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mykhailopylyp
mykhailopylyp approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@mykhailopylyp mykhailopylyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SeraphimaZykova SeraphimaZykova merged commit 7e79654 into microsoft:master Jun 22, 2021
@SeraphimaZykova SeraphimaZykova deleted the fz-closest-center branch June 22, 2021 08:34
royvou pushed a commit to royvou/PowerToys that referenced this pull request Jul 7, 2021
@SeraphimaZykova @royvou
[FancyZones] Avoid unnecessary calculations when selecting a zone (mi…
d84e582 
…crosoft#11815)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyoyuppe yuyoyuppe yuyoyuppe approved these changes

@mykhailopylyp mykhailopylyp mykhailopylyp approved these changes

Assignees
No one assigned
Labels
Product-FancyZones Refers to the FancyZones PowerToy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeraphimaZykova @yuyoyuppe @mykhailopylyp