Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FancyZones] Unit tests fix #12018

Merged
merged 2 commits into from
Jul 2, 2021
Merged

[FancyZones] Unit tests fix #12018

merged 2 commits into from
Jul 2, 2021

Conversation

SeraphimaZykova
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova commented Jun 30, 2021 •
edited
Loading

Summary of the Pull Request

What is this about:

  • Updated expected json in tests
  • Added constants

What is include in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: [FancyZones] Failing unit tests #12025
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@SeraphimaZykova SeraphimaZykova added the Product-FancyZones Refers to the FancyZones PowerToy label Jun 30, 2021
@mykhailopylyp
Copy link
Contributor

What is the motivation behind this change? Do we have a related issue?

@SeraphimaZykova
Copy link
Collaborator Author

What is the motivation behind this change? Do we have a related issue?

I opened an issue #12025

@SeraphimaZykova SeraphimaZykova added the Area-Tests issues that relate to tests label Jun 30, 2021
@SeraphimaZykova SeraphimaZykova merged commit 71f2561 into microsoft:master Jul 2, 2021
@SeraphimaZykova SeraphimaZykova deleted the fz-unit-tests-fix branch July 2, 2021 09:29
royvou pushed a commit to royvou/PowerToys that referenced this pull request Jul 7, 2021
@SeraphimaZykova @royvou
[FancyZones] Unit tests fix (microsoft#12018)
c45f24a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykhailopylyp mykhailopylyp mykhailopylyp approved these changes

@yuyoyuppe yuyoyuppe Awaiting requested review from yuyoyuppe

Assignees
No one assigned
Labels
Area-Tests issues that relate to tests Product-FancyZones Refers to the FancyZones PowerToy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeraphimaZykova @mykhailopylyp