Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Color Picker] Logs #12157

Merged
merged 2 commits into from
Jul 2, 2021
Merged

[Color Picker] Logs #12157

merged 2 commits into from
Jul 2, 2021

Conversation

mykhailopylyp
Copy link
Contributor

@mykhailopylyp mykhailopylyp commented Jul 2, 2021 •
edited
Loading

Summary of the Pull Request

What is this about:
In #11942 it is hard to understand if the ColorPicker process started and doesn't work or it hasn't started on the startup. Here, we update logging to correlate between the runner logs and the ColorPicker process logs.

What is include in the PR:

  • Initialize logger on the module interface initialization. It was not initialized and we didn't get any logs before
  • Add logs to understand how the ColorPicker process is created and destroyed

How does someone test / validate:

  • Run Color Picker
  • Verify ColorPicker for logs

Quality Checklist

  • Linked issue: Color Picker #11942
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@mykhailopylyp
- Fixed module interface logs
903a1de 
- Added logs to correlate logs between the runner and color picker process
@mykhailopylyp
Fix logs
df4175b
@mykhailopylyp mykhailopylyp added Product-Color Picker All things around the Color Picker utility Area-Logging Issues regarding the PowerToys logging facility labels Jul 2, 2021
jaimecbernardo
jaimecbernardo approved these changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as expected. Good work!

SeraphimaZykova
SeraphimaZykova approved these changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, logs are in place.

htcfreek
htcfreek approved these changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't try. But looks good to me.

@mykhailopylyp mykhailopylyp merged commit 25ab4af into microsoft:master Jul 2, 2021
@mykhailopylyp mykhailopylyp deleted the issue-11942 branch July 2, 2021 16:54
royvou pushed a commit to royvou/PowerToys that referenced this pull request Jul 7, 2021
@mykhailopylyp @royvou
[Color Picker] Logs (microsoft#12157)
f51f816 
* - Fixed module interface logs

- Added logs to correlate logs between the runner and color picker process

* Fix logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeraphimaZykova SeraphimaZykova SeraphimaZykova approved these changes

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

@htcfreek htcfreek htcfreek approved these changes

@yuyoyuppe yuyoyuppe Awaiting requested review from yuyoyuppe

Assignees
No one assigned
Labels
Area-Logging Issues regarding the PowerToys logging facility Product-Color Picker All things around the Color Picker utility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mykhailopylyp @SeraphimaZykova @jaimecbernardo @htcfreek