[Settings] Aligning XAML across all pages #12212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 4, 2021 22:26
stefansjfw
reviewed
Jul 5, 2021
src/settings-ui/Microsoft.PowerToys.Settings.UI/Controls/SidePanel/SidePanelLink.cs
Outdated
Show resolved
Hide resolved
src/settings-ui/Microsoft.PowerToys.Settings.UI/Strings/en-us/Resources.resw
Show resolved
Hide resolved
|
Nice work! Beside few minor comments, great improvement! |
stefansjfw
approved these changes
Jul 5, 2021
Fixed the unused namespaces issue. |
royvou
pushed a commit
to royvou/PowerToys
that referenced
this pull request
Jul 7, 2021
* Updating settings * OOBE button * Removed unused namespaces Co-authored-by: Niels Laute <niels9001@hotmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR introduces a re-usable user control that contains the entire page layout and re-sizing logic. Instead of having the same XAML on 11 pages, we now have 1 control we can adjust so making UI tweaks in the future is easier and we reduce any inconsistency. It also makes the pages easier to read and re-use.
Fixed with this issue: #12073
This paves the way of solving (and reducing) accessibility issues in the future such as #12023
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.