[Bug Report Tool] Report installation folder structure #12425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykhailopylyp
added
the
Area-Bug Report Tool
yuyoyuppe
reviewed
Jul 19, 2021
| #include <common/utils/winapi_error.h> | ||
|
|
||
| using namespace std; | ||
| using std::filesystem::directory_iterator; |
There was a problem hiding this comment.
nit: btw we could do namespace aliases, e.g. using fs = std::filesystem
There was a problem hiding this comment.
I don't want to use acronyms for namespaces' names
yuyoyuppe
approved these changes
Jul 19, 2021
jaimecbernardo
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
What is include in the PR:
installationFolderStructure.txtGetVersionwas adopted from https://docs.microsoft.com/en-us/windows/win32/seccrypto/example-c-program--creating-an-md-5-hash-from-file-contentHow does someone test / validate:
BugReportTool.exetoC:\Program Files\PowerToys\ToolsinstallationFolderStructure.txtand the one posted hereinstallationFolderStructure.txt
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.