-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging for PowerRename #14249
Add logging for PowerRename #14249
Conversation
Move call tracer to common/utils/logger Add logging to both PowerRename dll and PowerRenameUIHost Add PowerRename to BugReportTool event viewer collection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefansjfw
There is another list for bugreport on compat flags method. Dont ask me how it's called.
See #11561.
@jaimecbernardo
Can you plz block merging for this PR. Thanks.
@stefansjfw |
@htcfreek Let's do this one first then:
I'll go through code and check out what could throw and add logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking merge on request.
I think requesting changes will block it.
Now that #14296 is merged we can fix conflicts here, review it and unblock/merge this PR. |
Done. Let's do another round of review before merging. |
Can try it tomorrow. Maybe I get logs for #14180. |
That would be great, as I can't repro that one. Thanks! |
Are there any dev builds I can install without needing to build the installer? |
No, but you can run PowerRename directly by setting PowerRenameUIHost as a startup project. If you want to include items to rename , just add path here: |
@stefansjfw |
Well, I added exception logging where I was expecting them.. :) This shouldn't have happened there, |
I am okay with what we have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unblocking. Rubberstamp LGTM
Move call tracer to common/utils/logger
Add logging to both PowerRename dll and PowerRenameUIHost
Add PowerRename to BugReportTool event viewer collection
Summary of the Pull Request
What is this about:
Logging general PowerRename logic. Not logging any file names to avoid collecting sensitive user data.
What is include in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.