Revert "[PT Run] Smooth scrolling of the results list (#15033)" #15420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3ada3c2.
|
@crutkas , Some number of recent issues have been opened about this. |
davidegiacometti
approved these changes
Jan 10, 2022
|
@jaimecbernardo I have a laptop where the issue is very annoying: launcher freeze with empty results for several seconds so I approve the hotfix. |
stefansjfw
approved these changes
Jan 10, 2022
|
@jaimecbernardo For reproduction:
|
|
just verifying, have we validated this has resolved the regression? Agree on hotfix candidate |
1 task
jaimecbernardo
added a commit
that referenced
this pull request
Jan 11, 2022
This reverts commit 3ada3c2.
voruti
added a commit
to voruti/PowerToys
that referenced
this pull request
Mar 6, 2023
…soft#15420)" This reverts commit b609403.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
#15033 added some smoothness to scrolling but created input delays when typing in PowerToys Run (likely due to the side effect of disabling list virtualization. This makes for a worse experience than the issue the change fixed initially.
What is included in the PR:
This reverts commit 3ada3c2. (PR #15033 )
How does someone test / validate:
PowerToys Run keeps working, removing the input delay. This has been confirmed by users across these issues:
#15364
#15317
Quality Checklist