Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nuget packages #16379

Merged

Conversation

CleanCodeDeveloper
Copy link
Contributor

@CleanCodeDeveloper CleanCodeDeveloper commented Feb 15, 2022

Summary of the Pull Request

What is this about:
Updating nuget packages to latest version.

What is included in the PR:
Nuget package upgrade for csproj files (i did not touch *.vcxproj).

This is how it looks now:
image

All nuget packages on the screenshot are in vcxproj except UnitsNet, Mircosoft.UI.Xaml, System.IO.Abstractions. Those packages had a few breaking changes and should be updated in a separate PR.

Binaries:
image

Added:
5x System.Text.Json.dll

Removed:
1x Microsoft.Extensions.Configuration.dll
1x Microsoft.Extensions.Configuration.Binder.dll

How does someone test / validate:
Updating dependencies can be dangerous. Please test carefully.

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@CleanCodeDeveloper CleanCodeDeveloper marked this pull request as ready for review February 17, 2022 08:23
@stefansjfw
Copy link
Collaborator

We had issues with some tests not being run when we tried updating

    <PackageReference Include="MSTest.TestAdapter" Version="2.2.3" />
    <PackageReference Include="MSTest.TestFramework" Version="2.2.3" />

We need to see if that's resolved..

Also updating Microsoft.UI.Xaml had additional dependencies with newer versions. Let's just be careful here

@stefansjfw stefansjfw self-requested a review February 17, 2022 13:19
@stefansjfw
Copy link
Collaborator

image

Yeah, the same group of tests is still not being run with later versions of TestAdapter and TestFramework (> 2.2.3)

@CleanCodeDeveloper
Copy link
Contributor Author

We had issues with some tests not being run when we tried updating

    <PackageReference Include="MSTest.TestAdapter" Version="2.2.3" />
    <PackageReference Include="MSTest.TestFramework" Version="2.2.3" />

We need to see if that's resolved..

I first though it would be a local issue on my machine. I downgraded to 2.2.3 and can run all the tests again.

It would be great if someone from Microsoft who works on the MSTest.* library chimes in and explains what's going on. Never had any issues with these libraries until they version 2.2.4.

Also updating Microsoft.UI.Xaml had additional dependencies with newer versions. Let's just be careful here

Microsoft.UI.Xaml was tricky too. 2.7.0 does not work but 2.7.1-preview seems to be fine.

@crutkas
Copy link
Member

crutkas commented Feb 18, 2022

sending the signing agent against to just validate

Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested. looks good. Thanks for contribution!

@jaimecbernardo
Copy link
Collaborator

Microsoft.UI.Xaml was tricky too. 2.7.0 does not work but 2.7.1-preview seems to be fine.

This is because of our use of XAML islands. Only prerelease versions of Microsoft.UI.XAML have support for it.

Thanks a lot for the contribution!

@jaimecbernardo jaimecbernardo merged commit 4572f62 into microsoft:main Feb 18, 2022
@CleanCodeDeveloper CleanCodeDeveloper deleted the feature/update-nuget-packages branch February 18, 2022 18:03
@stefansjfw stefansjfw mentioned this pull request Dec 28, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants