[PowerRename][ImageResizer] Tier1 Win11 Context menu #19000

stefansjfw · 2022-06-23T09:25:43Z

Summary of the Pull Request

Add tier1 context menu items (Win11) for PowerRename and ImageResizer:

Also, with tier1 context menu PowerRename can be started by right-clicking directory background (no need to select items):

PR Checklist

Detailed Description of the Pull Request / Additional comments

Tier1 context menu are added by registering sparse packages for both PowerRename and ImageResizer. Packages are registered per user on module->enable() (conditionally if win11 and if not already registered). Packages are unregistered on PowerToys uninstall.

Also, minimum supported windows version is bumped to 10.0.19041.0 as sparse packaged registration API is added there. Also, end of support for previously used min version (10.0.18362.0) was 2022-05-10.

ImageResizer settings and trace files are extracted to ImageResizerLib project, to be able to consume those both from Ext and ContextMenu projects.

As CreateProcess can't run new proces from packaged app (sparse package here), PowerRename and ImageResuzer are being ran with explorer as parent process. Therefore, additional logic is added to use named pipes in that case (comparing to default stdin anonymous pipes when standard context menu is used).

Validation Steps Performed

Build installer and install PowerToys on Win11
Sign sparse packages manually in order to be registered successfully
Enable PowerRename and ImageResizer modules (if not enabled)
Check from PowerShell that packages are registered e.g. powershell -c get-appxpackage -name *imageresizer*
If packages are registered and items are not visible in tier1 context menu, explorer needs to be restarted (known issue)

…ft/PowerToys into stefan/tier1_contextmenu

Add PowerToys preffix Add assets to installer

Unregister package on uninstall Remove unneeded files Cleanup

FindPackages() method needs admin privileges. This reverts commit 5af584f.

Minor cleanups Move logic to package.h

Expect.txt

Cpp.Build.props

src/common/utils/package.h

Jay-o-Way · 2022-06-23T11:39:20Z

I see you chose these two items in the main menu — no sub-menu?
I suppose this doesn't have any effect on Win.10 at all?

PowerRename can be started by right-clicking directory background

Does this also apply to "special" folders? / is there a check to prevent critical (system/user) folders being renamed?

stefansjfw · 2022-06-23T11:48:25Z

I see you chose these two items in the main menu — no sub-menu?

The idea is to add tier1 support and keep it as it was in standard context menu for now. If we want to group items in single PowerToys menu, it should be like that for both Win10 and Win11 menus. That would need some additional rework for both logics.

I suppose this doesn't have any effect on Win.10 at all?

No, it doesn't.

Does this also apply to "special" folders? / is there a check to prevent critical (system/user) folders being renamed?

Good point, I'll double check this.

- check if selection renamable - minor cleanup - struct initialization

stefansjfw · 2022-06-23T14:04:14Z

Does this also apply to "special" folders? / is there a check to prevent critical (system/user) folders being renamed?

Done

lncubus · 2022-06-23T14:12:02Z

This is a big one. Quite a fix for 19k!

htcfreek · 2022-06-28T08:46:16Z

@stefansjfw

What AUMID will the two packages have?

PowerRenameContextMenu_1.0.0.0_neutral__8wekyb3d8bbwe
ImageResizerContextMenu_1.0.0.0_neutral__8wekyb3d8bbwe

I think something like Microsoft.PowerToys.*** is better. This helps for AppX-Whitelists with regex match and makes admins life easier.
And it is more clear where the packages come from.

stefansjfw · 2022-06-28T09:26:11Z

I think something like Microsoft.PowerToys.*** is better. This helps for AppX-Whitelists with regex match and makes admins life easier.

Makes sense. Added. Thanks

…e error Don't generate empty STRINGTABLE for resx files without data

niels9001 · 2022-06-29T14:08:15Z

@stefansjfw Ugh, you can't imagine how much joy this brings me haha :). Great job!

…ft/PowerToys into stefan/tier1_contextmenu

jaimecbernardo

LGTM! Great work!
After merging this, please open an issue regarding investigating how to avoid needing to restart explorer for the context menu to recognize the new entries under Windows 11.

htcfreek · 2022-06-30T10:15:59Z

@stefansjfw
Can you please open the issue for Terminal plugin too?

htcfreek · 2022-06-30T13:01:24Z

@stefansjfw
Can you please open the issue for Terminal plugin too?

And an issue to add package check to bugreport tool.

stefansjfw · 2022-06-30T17:20:43Z

@stefansjfw
Can you please open the issue for Terminal plugin too?

And an issue to add package check to bugreport tool.

Added package check to bugreport tool

htcfreek · 2022-06-30T17:56:01Z

tools/BugReportTool/BugReportTool/Package.cpp

+    }
+    catch (...)
+    {
+        printf("Failed to report installed context menu packages");


We should catch per package and we should write xyz: not found/registered if a package isn't inatalled. This makes reading/analyzing the bug report easier.

Do you improve this in a second step?

I think it's a minor difference.. we only have 2 packages to report. If package is not listed in the file - it's not installed/registered, so as soon as someone open the file it's clear whether all packages are there or not

stefansjfw · 2022-06-30T18:59:48Z

Created
#19124
#19123

stefansjfw added 18 commits May 31, 2022 15:09

Test win11 tier1 context menu

2492517

Try to test signing

94b3d09

Cleanup

05320f4

Cleanup project file

a000d30

Merge branch 'stefan/tier1_contextmenu' of https://github.com/microso…

677707d

…ft/PowerToys into stefan/tier1_contextmenu

Sign dll

539fe04

Add PowerToys preffix Add assets to installer

expect.txt

0fbb14c

Switch to named pipes

c6d8ac5

Unregister package on uninstall Remove unneeded files Cleanup

Bring back check if package registered but use per-user method

4c9cc1b

Fix win11 check

e53398b

expect.txt

558ff88

Check if package already registered

5af584f

Revert "Check if package already registered"

ff06337

FindPackages() method needs admin privileges. This reverts commit 5af584f.

Fix PowerRename args checking

5e89a82

Cleanup assets

a2ce420

Merge remote-tracking branch 'origin/main' into stefan/tier1_contextmenu

50c4079

Tier1 context menu ImageResizer

0ed3aef

Minor cleanups Move logic to package.h

[WIP] Signing and installer

39111d8

Expect.txt

stefansjfw requested review from yuyoyuppe, lncubus, SeraphimaZykova and jaimecbernardo June 23, 2022 09:25

yuyoyuppe reviewed Jun 23, 2022

View reviewed changes

Cpp.Build.props Show resolved Hide resolved

src/common/utils/package.h Outdated Show resolved Hide resolved

stefansjfw added 3 commits June 23, 2022 15:59

Localized context menu title

d73b672

Retarget everything 10.0.18362.0 -> 10.0.19041.0

ef1ba2c

Address PR comments

e957996

- check if selection renamable - minor cleanup - struct initialization

Add Microsoft.PowerToys prefix to packages

fe1ee53

stefansjfw added 2 commits June 28, 2022 11:27

Merge remote-tracking branch 'origin/main' into stefan/tier0_contextmenu

5445f83

Test

82f07cc

stefansjfw force-pushed the stefan/tier1_contextmenu branch 2 times, most recently from ff727c9 to 1fb705f Compare June 28, 2022 14:25

Fix convert-resx-to-rc.ps1 script issue causing resource files compil…

1dc5b54

…e error Don't generate empty STRINGTABLE for resx files without data

stefansjfw force-pushed the stefan/tier1_contextmenu branch from 1fb705f to 1dc5b54 Compare June 28, 2022 15:55

microsoft deleted a comment from github-actions bot Jun 29, 2022

stefansjfw added 2 commits June 29, 2022 18:56

Avoid duplicate context menu items

c7a3a80

Merge branch 'stefan/tier1_contextmenu' of https://github.com/microso…

63f8fb1

…ft/PowerToys into stefan/tier1_contextmenu

jaimecbernardo approved these changes Jun 30, 2022

View reviewed changes

SeraphimaZykova approved these changes Jun 30, 2022

View reviewed changes

[BugReportTool] Report installed context menu packages

c38738c

htcfreek suggested changes Jun 30, 2022

View reviewed changes

This was referenced Jun 30, 2022

Use package API to get installed Terminal packages #19123

Closed

Win11 tier 1 context menu needs explorer.exe restart #19124

Open

stefansjfw merged commit e637902 into main Jun 30, 2022

crutkas deleted the stefan/tier1_contextmenu branch July 6, 2022 16:06

crutkas mentioned this pull request Jul 11, 2022

Show installer error in settings on failure. #19337

Closed

1 task

htcfreek mentioned this pull request Jul 22, 2022

PowerRenameContextMenu_1.0.0.0_neutral__8wekyb3d8bbwe stopped working (Windows Reliability History) #19575

Closed

1 task

stefansjfw mentioned this pull request Jul 22, 2022

[PowerRename] Prefix sparse package with Microsoft.PowerToys #19580

Closed

noorkator mentioned this pull request Aug 2, 2022

... investigating how to avoid needing to restart explorer for the context menu to recognize the new entries under Windows 11. noorkator/github-actions-continuous-delivery-azure#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PowerRename][ImageResizer] Tier1 Win11 Context menu #19000

[PowerRename][ImageResizer] Tier1 Win11 Context menu #19000

stefansjfw commented Jun 23, 2022 •

edited

Loading

Jay-o-Way commented Jun 23, 2022

stefansjfw commented Jun 23, 2022

stefansjfw commented Jun 23, 2022

lncubus commented Jun 23, 2022

htcfreek commented Jun 28, 2022 •

edited

Loading

stefansjfw commented Jun 28, 2022

niels9001 commented Jun 29, 2022

jaimecbernardo left a comment

htcfreek commented Jun 30, 2022

htcfreek commented Jun 30, 2022

stefansjfw commented Jun 30, 2022

htcfreek Jun 30, 2022 •

edited

Loading

htcfreek Jun 30, 2022

stefansjfw Jun 30, 2022

stefansjfw commented Jun 30, 2022 •

edited

Loading

[PowerRename][ImageResizer] Tier1 Win11 Context menu #19000

[PowerRename][ImageResizer] Tier1 Win11 Context menu #19000

Conversation

stefansjfw commented Jun 23, 2022 • edited Loading

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Jay-o-Way commented Jun 23, 2022

stefansjfw commented Jun 23, 2022

stefansjfw commented Jun 23, 2022

lncubus commented Jun 23, 2022

htcfreek commented Jun 28, 2022 • edited Loading

stefansjfw commented Jun 28, 2022

niels9001 commented Jun 29, 2022

jaimecbernardo left a comment

Choose a reason for hiding this comment

htcfreek commented Jun 30, 2022

htcfreek commented Jun 30, 2022

stefansjfw commented Jun 30, 2022

htcfreek Jun 30, 2022 • edited Loading

Choose a reason for hiding this comment

htcfreek Jun 30, 2022

Choose a reason for hiding this comment

stefansjfw Jun 30, 2022

Choose a reason for hiding this comment

stefansjfw commented Jun 30, 2022 • edited Loading

stefansjfw commented Jun 23, 2022 •

edited

Loading

htcfreek commented Jun 28, 2022 •

edited

Loading

htcfreek Jun 30, 2022 •

edited

Loading

stefansjfw commented Jun 30, 2022 •

edited

Loading