Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Move all installer registry entries to HKCU #23252

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

stefansjfw
Copy link
Collaborator

@stefansjfw stefansjfw commented Jan 10, 2023

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Build installer , install PT and test all modules with focus on the ones using changed registry entries: PowerRename, Thumbnail/Preview handlers, ImageResizer

<RegistryValue Root="HKCU"
Key="SOFTWARE\Classes\*\ShellEx\ContextMenuHandlers\PowerRenameExt"
Value="{0440049F-D1DC-4E46-B27B-98393D79486B}"
Type="string" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this one missing before? :O

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah, this was a leftover of trying to make PowerRename work when right-click inside folder (not items) bit it didn't work. moving back to the same reg key...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works the same both ways, though

@stefansjfw
Copy link
Collaborator Author

Hi. If this is #15516, please link? :)

yes, it's a part of that work. Thanks. Linked

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@stefansjfw stefansjfw merged commit da45647 into main Jan 16, 2023
@stefansjfw stefansjfw deleted the stefan/reg_to_HKCU branch January 16, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants