Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FancyZones] Opacity reset fix #23818

Merged
merged 1 commit into from
Feb 3, 2023
Merged

[FancyZones] Opacity reset fix #23818

merged 1 commit into from
Feb 3, 2023

Conversation

SeraphimaZykova
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova commented Feb 3, 2023 •
edited by jaimecbernardo
Loading

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Turn on Make dragged window transparent option
  • Open the Magic: The Gathering Online or Unity window
  • Drag it without snapping
  • Make sure the opacity hasn't changed and window looks and works as before

stefansjfw
stefansjfw approved these changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. didn't test it

@jaimecbernardo
Copy link
Collaborator

#23760 was the recent issue where it seems this resurfaced.

@jaimecbernardo
Copy link
Collaborator

#23760 and #4451 aren't actually fixed by this PR. But this behavior still happened with .66, so it's not a regression. This PR does fix the issue reported on Twitter: https://twitter.com/archiecoder/status/1621341084369518592?s=43
Which was a regression for .67

@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label Feb 3, 2023
jaimecbernardo
jaimecbernardo approved these changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with MTGO and this fixes it. LGTM! Thank you!

@jaimecbernardo jaimecbernardo merged commit 82c5c00 into microsoft:main Feb 3, 2023
@SeraphimaZykova SeraphimaZykova deleted the 23773-fz-opacity branch February 3, 2023 15:11
stefansjfw pushed a commit that referenced this pull request Feb 6, 2023
@SeraphimaZykova @stefansjfw
[FancyZones][Hotfix]Opacity reset fix (#23818)
6668ec4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefansjfw stefansjfw stefansjfw approved these changes

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

Assignees
No one assigned
Labels
Hot Fix Items we will product an out-of-band release for
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeraphimaZykova @jaimecbernardo @stefansjfw