Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FancyZones] Remove app from app-zone-history when dragging starts #23926

Merged
merged 1 commit into from
Feb 7, 2023
Merged

[FancyZones] Remove app from app-zone-history when dragging starts #23926

merged 1 commit into from
Feb 7, 2023

Conversation

SeraphimaZykova
Copy link
Collaborator

Summary of the Pull Request

Unsnap the window every time when dragging starts.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Enable dragging while holding Shift
  • Snap window
  • Start dragging without holding shift
  • Verify app was removed from app-zone-history.json

@SeraphimaZykova SeraphimaZykova merged commit a6e0396 into microsoft:main Feb 7, 2023
@SeraphimaZykova SeraphimaZykova deleted the fz-unsnap branch February 7, 2023 11:14
jaimecbernardo pushed a commit that referenced this pull request Feb 7, 2023
@SeraphimaZykova @jaimecbernardo
[FancyZones] Remove app from app-zone-history when dragging starts (#…
9ffaa03 
…23926)
@koppor koppor mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefansjfw stefansjfw stefansjfw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeraphimaZykova @stefansjfw