[GPO] Add GPO to disable per-user install #25141
Conversation
Move per machine check to bootstrapper Move all defines to common.wxs Fix CI
Co-authored-by: Jeremy Sinclair <4016293+snickler@users.noreply.github.com>
Co-authored-by: Jeremy Sinclair <4016293+snickler@users.noreply.github.com>
Co-authored-by: Jeremy Sinclair <4016293+snickler@users.noreply.github.com>
This reverts commit 34545da.
It messes up app ID for per-user installation which ends up breaking winget update of the per-user PT
stefansjfw
force-pushed
the
stefan/per_user_gpo
branch
from
da8ae42
to
5c6392c
Compare
|
|
||
| inline gpo_rule_configured_t getDisablePerUserInstallationValue() | ||
| { | ||
| return getConfiguredValue(POLICY_DISABLE_PER_USER_INSTALLATION); |
There was a problem hiding this comment.
Should we add a mew method that only reads HKLM? In case someone sets the value manually in registry.
There was a problem hiding this comment.
Well, in that case, user would disable it for himself, right? So,no?
There was a problem hiding this comment.
I was a bit unclear. What I mean is we have a Machine (HKLM) only policy and checking both. This means that you still manually can set it in HKCU. Not sure if this something we should prevent. 🤔
There was a problem hiding this comment.
This means that you still manually can set it in HKCU
Yes, but who can? Current user? If the current user wants to disable per-user install for himself, so be it :)
There was a problem hiding this comment.
Okay. Then let's not overcomplicating thing and read both. I only want to mention it.
Yes, it says the same as others.. That administrator has disabled it. |
Co-authored-by: Heiko <61519853+htcfreek@users.noreply.github.com>
stefansjfw
changed the title
* Add per user installer * Separate upgrade codes for per machine and per user installation Move per machine check to bootstrapper Move all defines to common.wxs Fix CI * Update installer/PowerToysSetup/generateFileList.ps1 Co-authored-by: Jeremy Sinclair <4016293+snickler@users.noreply.github.com> * Update installer/PowerToysSetup/generateAllFileComponents.ps1 Co-authored-by: Jeremy Sinclair <4016293+snickler@users.noreply.github.com> * Update installer/PowerToysSetup/generateFileList.ps1 Co-authored-by: Jeremy Sinclair <4016293+snickler@users.noreply.github.com> * expect.txt * Revert "Update installer/PowerToysSetup/generateFileList.ps1" This reverts commit 34545da. * Update release CI to build both installers * Revert bundle name change It messes up app ID for per-user installation which ends up breaking winget update of the per-user PT * spellcheck * Fix bad merge * Add RegistryPreview * Include backup_restore_settings.json * Revert testing endpoint change * Add per-machine/per-user installation GPOs * Update doc/gpo/README.md * Update doc/gpo/README.md * spellcheck * Remove disable per-machine policy * Update doc/gpo/README.md Co-authored-by: Heiko <61519853+htcfreek@users.noreply.github.com> --------- Co-authored-by: Jeremy Sinclair <4016293+snickler@users.noreply.github.com> Co-authored-by: Heiko <61519853+htcfreek@users.noreply.github.com>
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed